Yaniv Bronhaim has posted comments on this change.

Change subject: multipath configurator: reload only if service is active
......................................................................


Patch Set 1: Code-Review+1

more right to say that over systemd "service multipathd reload" returns 127, 
but over initctl - 0 - when service is down. therefore, service.py throws 
exception and we don't get the runtimeError.

with this change we avoid the reload at all if service is down.

this bug suppose to exist over fedora for long time afaiu . please update the 
bugzilla and consider where this fix should be backported.

-- 
To view, visit http://gerrit.ovirt.org/36387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to