Dan Kenigsberg has posted comments on this change. Change subject: multipath configurator: reload only if service is active ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 146 Line 147 Line 148 Line 149 Line 150 > it is the same, but systemd returns different value for the reload call and Yaniv: assume that a service is not running, and then service.service_reload() is called. What happens? Yeela tells me that the answer depends on whether we're using systemd or sysv. It should not. The whole point of the service module is to give us a common interface to all 3 service management systems. -- To view, visit http://gerrit.ovirt.org/36387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
