Yaniv Bronhaim has posted comments on this change.

Change subject: asyncore: Move ssl buffer handling to dispatcher
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/37097/4/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 88:         if self.accepting:
Line 89:             self.handle_accept()
Line 90:             return
Line 91: 
Line 92:         if not self.connected:
please change to elif not
Line 93:             if self.connecting:
Line 94:                 self.handle_connect_event()
Line 95: 
Line 96:         self.handle_read()


-- 
To view, visit https://gerrit.ovirt.org/37097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to