At 22:55 2001-02-19, Paulo wrote:
>Hi David,
Hi Paulo!
>At a first glance:
> - DBResourceLoader.isSourceModified() has too much code in common
> with DBResourceLoader.getLastModified();
> - There is some more code repeated.
>
>Without (almost) changing the functionality, what about this
>implementation (just the DBResourceLoader class)?
>
>
>Paulo
[new implementation snipped]
Yup. Looks fine to me. It was a first iteration anyway. :-)
I read your previous post regarding placement of this loader
and the need for other methods of getting resources from
databases. How about resolving some of the issues by renaming
this particular loader to DataSourceResourceLoader instead of
DBResourceLoader? That would emphasize the fact that it is
DataSource specific and leave the field open for other
database-related loaders while eliminating naming conflicts?
/David
