Hi Geir,


Then "ReferenceInsertionEventHandler.referenceInsert()" keeps its name?


I am making this remark because I suggested renaming it to:
  "ReferenceRenderEventHandler.referenceRender()"

and you answer was
> That's good too - I think that the 'Insert' came from the notion of
> 'inserting' into the output stream.


Of course that I prefer the name I suggested (I think it is less 
ambiguous), but I can take a conscious "no" too. I just want to make
sure that you didn't just forget it. (Your well fundamented NO's are
usually quite ok with me.)


Thanks,
Paulo Gaspar


> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On
> Behalf Of Geir Magnusson Jr.
> 
> ...
>
> 2) The NullSetEventHandler was changed - the method the interface
> defines was changed from :
> 
>   public boolean nullSetEventLogMessage( String reference )
> 
>   <or something like that>
> 
> to 
> 
>   public boolean shouldLogOnNullSet( String left, String right )
> 
> which seems to be more descriptive.  if you don't like this, we still
> can change.  I also added the second arg, so you can see what the LHS
> and the RHS are for a #set().  Figured it couldn't hurt.
>
> ...
>
> geir

Reply via email to