Geir, Yes - VelocityViewServlet was OK when I got the head branch today (almost said "when I got head", but that would have been impolite :).
Out of curiousity, is this your first serious, day-in/day-out, use of a mac? OS X.1, right? How do you like it so far? What JVM do you use with that? Thanks again, Donnie > -----Original Message----- > From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED]] > Sent: Friday, January 04, 2002 10:17 PM > To: Velocity Developer's List > Subject: Re: [ANN] Struts + Velocity + Tools +... > > > On 1/4/02 10:18 PM, "Donnie Hale" <[EMAIL PROTECTED]> wrote: > > > Geir, > > > > I appreciate you doing this. Note that since my last message, > I've seen the > > same problem in most of the property files, deployment > descriptors, etc. in > > velocity-tools. > > > > > The problem comes from "Unsafe Rapid Prototyping" - trading code w/o a > protection. Gabriel and I went back and forth quite a bit with stuff. I > will blame him :) > > I use a mac now, so my line endings should be even weirder. > > VelocityViewServlet is ok right? > > > Donnie > > > > > >> -----Original Message----- > >> From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED]] > >> Sent: Friday, January 04, 2002 9:59 PM > >> To: Velocity Developer's List > >> Subject: Re: [ANN] Struts + Velocity + Tools +... > >> > >> > >> On 1/4/02 9:32 PM, "Donnie Hale" <[EMAIL PROTECTED]> wrote: > >> > >>> Geir, > >>> > >>> I saw you committed a change to fix the "\x0D\x0D\x0A" issue. > I've also > >>> noticed the same problem in: > >>> > >>> > view\src\java\org\apache\velocity\tools\view\context\ToolboxContext.java > >>> > view\src\java\org\apache\velocity\tools\view\context\ChainedContext.java > >>> struts\src\java\org\apache\velocity\tools\struts\ContextHelper.java > >>> struts\src\java\org\apache\velocity\tools\struts\StrutsBeanTool.java > >>> struts\src\java\org\apache\velocity\tools\struts\StrutsHtmlTool.java > >>> struts\src\java\org\apache\velocity\tools\struts\ToolLoaderTool.java > >>> struts\src\java\org\apache\velocity\tools\struts\ViewHelper.java > >>> struts\examples\struts\WEB-INF\src\examples\app1\*.java > >>> struts\examples\struts\WEB-INF\src\examples\app2\*.java > >>> struts\examples\struts\WEB-INF\src\examples\app3\ContinueAction.java > >>> > >>> I think I've checked all the .java files within velocity-tools > >> now. Sorry, > >>> but thanks. :) > >>> > >>> For future reference, it appears that the correct files use > >> "\x0D\x0A" (the > >>> DOS, not Unix, format). Is that right? Do you do something > >> particular to fix > >>> this that's easier for you as a committer? If not, I can fix > >> them and submit > >>> a .zip with the corrected files. I'm guessing that diff > >> wouldn't handle this > >>> kind of a change real well? > >>> > >>> Donnie > >> > >> I'll fix. No worries. Thx for the heads-up > >> > >> > >> -- > >> Geir Magnusson Jr. [EMAIL PROTECTED] > >> System and Software Consulting > >> "Whoever would overthrow the liberty of a nation must begin by > >> subduing the > >> freeness of speech." - Benjamin Franklin > >> > >> > >> > >> -- > >> To unsubscribe, e-mail: > > <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: > > <mailto:[EMAIL PROTECTED]> > > > > > > > > -- > > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > -- Geir Magnusson Jr. [EMAIL PROTECTED] System and Software Consulting "Whoever would overthrow the liberty of a nation must begin by subduing the freeness of speech." - Benjamin Franklin -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
