Donnie, I checked out everything and looked at several of the files you listed. I don't see any problem. Ultraedit recognizes the files properly as UNIX files. I looked at some of the files in Hex mode. All lines seem properly terminated with 0A 0D
Where/how exactely do you see this problem? Gabe Donnie Hale wrote: > > Geir, > > I saw you committed a change to fix the "\x0D\x0D\x0A" issue. I've also > noticed the same problem in: > > view\src\java\org\apache\velocity\tools\view\context\ToolboxContext.java > view\src\java\org\apache\velocity\tools\view\context\ChainedContext.java > struts\src\java\org\apache\velocity\tools\struts\ContextHelper.java > struts\src\java\org\apache\velocity\tools\struts\StrutsBeanTool.java > struts\src\java\org\apache\velocity\tools\struts\StrutsHtmlTool.java > struts\src\java\org\apache\velocity\tools\struts\ToolLoaderTool.java > struts\src\java\org\apache\velocity\tools\struts\ViewHelper.java > struts\examples\struts\WEB-INF\src\examples\app1\*.java > struts\examples\struts\WEB-INF\src\examples\app2\*.java > struts\examples\struts\WEB-INF\src\examples\app3\ContinueAction.java > > I think I've checked all the .java files within velocity-tools now. Sorry, > but thanks. :) > > For future reference, it appears that the correct files use "\x0D\x0A" (the > DOS, not Unix, format). Is that right? Do you do something particular to fix > this that's easier for you as a committer? If not, I can fix them and submit > a .zip with the corrected files. I'm guessing that diff wouldn't handle this > kind of a change real well? > > Donnie > > > -----Original Message----- > > From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED]] > > Sent: Thursday, January 03, 2002 8:42 PM > > To: Velocity Developer's List > > Subject: Re: [ANN] Struts + Velocity + Tools +... > > > > > > On 1/3/02 8:29 PM, "Donnie Hale" <[EMAIL PROTECTED]> wrote: > > > > > Geir, Ted, and Gabriel: > > > > > > Thanks so much for this effort. I haven't gotten to work with > > it yet, but > > > I'm excited to start trying it. > > > > > > One thing (sorry :) - when I opened up the source file in "view" - > > > > > org/apache/velocity/tools/view/servlet/VelocityViewServlet.java, I noticed > > > that its line terminators are the sequence "\x0D\x0D\x0A". I > > haven't gone > > > through every .java file, but the other ones I opened seemed OK. > > > > Hm. I'll take a look > > > > > > > > FWIW... > > > > > > Donnie > > > > > > > > >> -----Original Message----- > > >> From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED]] > > >> Sent: Thursday, January 03, 2002 3:48 PM > > >> To: [EMAIL PROTECTED]; Velocity Developer's List > > >> Subject: [ANN] Struts + Velocity + Tools +... > > >> > > >> > > >> > > >> Real Soon Now is Now. > > >> > > >> Thanks to Gabriel and Ted for this as well as everyone that > > >> contributed and > > >> supported the discussion. > > >> > > >> > > >> There is a new CVS repository called > > >> > > >> jakarta-velocity-tools > > >> > > >> It is where we can put together our tool project. I will add this (and > > >> -dvsl) to the jakarta cvs page, but you can go there directly : > > >> > > >> http://cvs.apache.org/viewcvs/jakarta-velocity-tools/ > > >> > > >> And of course, for those that use CVS clients, just > > >> > > >> cvs checkout jakarta-velocity-tools > > >> > > >> > > >> Currently, there are two parts : > > >> > > >> View > > >> ===== > > >> This is a general purpose servlet that does tool loading, and is > > >> meant to be > > >> used in place of (or along side of) JspServlet. The toolbox stuff is > > >> rudimentary and untested (I put it together today) and there > > are lots of > > >> refinements to be made. View includes an example that uses > > Gabriel's cool > > >> self-building war, so to see how this works, just go to > > exmaple/simple and > > >> type > > >> > > >> ant devwar > > >> > > >> And then deploy that war. You can see it work with the simple > > >> index.vm - so > > >> to test, just point the browser at the servlet engine, and suppose you > > >> called the war strutsvel.war > > >> > > >> http://localhost:8080/strutsvel/index.vm > > >> > > >> And you will hopefully see it work > > >> > > >> There are a a few cool things in View that will probably migrate into > > >> Velocity proper, namely the WebappLoader, which does template > > loading via > > >> letting the container return input streams, and a ServletLogger, > > >> which lets > > >> the velocity log stuff go to the servlet log file for convenience. > > >> > > >> These features depend on the current 1.3-dev jar, which is included. > > >> > > >> > > >> Struts > > >> ====== > > >> This is a package that contains the stuff needed to connect Struts and > > >> Velocity, and the overwhelming majority of the hard work was done > > >> by Gabriel > > >> Sidler and Ted Husted (from Struts-land). > > >> > > >> It has the same project structure as View, you can build the jar, > > >> but there > > >> is an excellent example WAR put together by Gabriel with major > > >> contributions > > >> by Ted that show three or so apps done using Struts both with JSP and > > >> Velocity, so you can compare and contrast. > > >> > > >> That too should be in the example/struts directory and a > > >> > > >> ant devwar > > >> > > >> should build it. Deploy and enjoy. > > >> > > >> There are a few tools in here that are going to come back out > > because they > > >> are generic and go live in View or Tools. I got sick of moving > > >> things around > > >> today :) > > >> > > >> One really cool thing is that no special Struts support is required for > > >> this, and it works with struts 1.0, the released version. Hats off to > > >> Gabriel for this (if you wear a hat...). > > >> > > >> Once this is reasonably tested and we do a release, we'll add > > >> Struts to our > > >> list of supported frameworks :) > > >> > > >> > > >> And coming : > > >> > > >> > > >> Tools > > >> ===== > > >> Not checked in yet, this will be a general tool space, where we > > >> can grab the > > >> stuff in commons-sandbox/rupert and give care and feeding > > >> > > >> > > >> VM > > >> == > > >> Not started. Need some ideas - basically a collection of VMs > > >> > > >> > > >> > > >> Sorry about the delay (but some things are worth waiting for). > > >> > > >> I'll add links from the Velocity site and make nightly's later today. > > >> > > >> > > >> Also, if someone has better ideas on how this might be organized and > > >> arranged, just speak up... > > >> > > >> > > >> -- > > >> Geir Magnusson Jr. > > [EMAIL PROTECTED] > > >> System and Software Consulting > > >> "We will be judged not by the monuments we build, but by the > > monuments we > > >> destroy" - Ada Louise Huxtable > > >> > > >> > > >> -- > > >> To unsubscribe, e-mail: > > >> <mailto:[EMAIL PROTECTED]> > > >> For additional commands, e-mail: > > >> <mailto:[EMAIL PROTECTED]> > > >> > > >> > > > > > > > > > -- > > > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > > > -- > Geir Magnusson Jr. [EMAIL PROTECTED] > System and Software Consulting > You're going to end up getting pissed at your software > anyway, so you might as well not pay for it. Try Open Source. > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- Gabriel Sidler Software Engineer, Eivycom GmbH, Zurich, Switzerland -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
