Hello,
"Geir Magnusson Jr." wrote:
> Thanks, but you don't have to do this specially. My mailer problem are my
> mailer problems.
>
> Comments :
>
> 1) velocity-build-dvsl.patch (patching build.xml for dvsl) :
>
> - why didn't you like the descriptions?
I had no problem with them at all. However in Ant, any target with a
description attribute shows up under the Main targets section when running
ant -projecthelp. Targets without descriptions show up under the
Subtargets section. After applying my patch ant -projecthelp will look
like this:
Buildfile: build.xml
Default target:
jar Creates jar file
Main targets:
all Clean, build jar, generate docs and javadocs
clean Clean build and distribution directories
compile Compile
compile-tests Compile Testcases
docs Generate documentation
docs-printable Generate printable documentation
install-jar Installs .jar file in ${lib.repo}
jar Creates jar file
javadocs Create Javadoc documentation
test Run all unit tests
Subtargets:
docs-init
init
prepare
static
test.transform
In the current build.xml, the init, prepare and static targets all show up
under the Main targets section. It didn't seem to me anyone should run
these targets directly so by removing the description attribute from each
of them, the target droped into the Subtargets section. Conversely, the
docs, docs-printable and jar targets didn't have descriptions so I added
descriptions making these targets move up to the Main targets section
where they show be.
> - And you can't blow away ${docs.dest} in the "clean" target as that is a
> CVS-ed directory along with the contents - we follow the sometimes
> frowned-upon approach of checking in the rendered .html so it comes included
> in nightly snapshots as well as being easy to cvs update out onto the
> jakarta site.
Okay. In 0.32 I didn't recall a populated docs directory.
Maybe there should be a clean-docs target or similar that deletes just the
docs directories.
> - We can commit w/o the delete of the ${docs.dest} if you want.
Sounds good.
> 2) stylesheets patch : Committed.
Thanks!
-Bill
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
