Hello,

"Geir Magnusson Jr." wrote:
> 
> On 2/13/02 11:15 PM, "Bill Burton" <[EMAIL PROTECTED]> wrote:
> 
> > Hello,
> >
> > "Geir Magnusson Jr." wrote:
> >>
> >> On 2/13/02 4:50 PM, "Bill Burton" <[EMAIL PROTECTED]> wrote:
> >>>>  - And you can't blow away ${docs.dest} in the "clean" target as that is a
> >>>> CVS-ed directory along with the contents - we follow the sometimes
> >>>> frowned-upon approach of checking in the rendered .html so it comes
> >>>> included
> >>>> in nightly snapshots as well as being easy to cvs update out onto the
> >>>> jakarta site.
> >>>
> >>> Okay.  In 0.32 I didn't recall a populated docs directory.
> >>>
> >>> Maybe there should be a clean-docs target or similar that deletes just the
> >>> docs directories.
> >>
> >> I assume you mean contents
> >
> > Does it matter as the task will recreate them (docs and docs-print)
> > anyway?
> 
> In the current practice, yes - if you remove the directory, then I can't
> check in the updated docs...

I see.

> >
> > In thinking about this further, since the generated docs are in CVS, the
> > docs target should not overwrite anything in that directory.  Instead, the
> > docs and docs-print targets should output to the target directory.  A new
> > target in the build.xml, "dist" can then be used to delete docs and then
> > copy target/docs to docs.  If that sounds okay, I'll submit a patch.
> 
> That's not how I work - not that it matters much, but just to let you know.
> Updating the docs isn't a grandiose 'dist' type of thing.  If something
> changes, I simply
> 
>  $ ant docs
>   (go take a look to make sure ok)
>  $ cvs commit xdocs/foo.xml docs/foo.html
> 
> And then I'm done - I can update the website then...

Okay, that makes sense.

It only seemed like an issue because I've been testing various stuff
related to the docs and wanted to make sure I was starting from a clean
directory.  However, it seems the dependency checking logic inherited from
the <style> task is working fine so the target docs are only overwritten
if a source .xml or the .dvsl file has changed.  I guess I can also run
Ant with -Ddocs.dest=docs_test to use a different target directory.

> 
> > Longer term, it may be good to have a dist subirectory which would be
> > populated in an optimum manner for a binary distribution.
> 
> Yes
> 
> >
> > Also, there are lots of javadoc warnings because ant.jar isn't in the
> > <javadoc>'s classpath.  I can submit a patch for that at the same time.
> >
> 
> Yes

Okay, I'll submit a patch to fix this.

-Bill

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to