Thanks Claude! A couple small questions/suggestions though: what was your motivation for naming the factory method "getToolboxManager()"? It seems a little redundant to do "ServletToolboxManager.getToolboxManager(blah,blah)." i'd rather call it "getInstance()."
is there a reason to keep the ServletToolboxManager's constructor public? it seems to me we ought to make it private (or protected at least). Nathan Bubna [EMAIL PROTECTED] ----- Original Message ----- From: Claude Brisson To: [EMAIL PROTECTED] Sent: Tuesday, January 21, 2003 11:08 AM Subject: [VELTOOLS] [patch] ServletToolboxManager Here is my previously proposed patch : one ServletToolboxManager per toolbox.xml file, so that application-scoped tools are initialized only once (even if there are several servlets). Tests ok, fully backward compatible. It also includes my previous one-line patch that will search for the toolbox param in the context if not found in the servlets param. (it is not yet possible to specify an alternate ServletToolboxManager class name via init-params, that's quite orthogonal...) CloD -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
