[ http://issues.apache.org/jira/browse/VELOCITY-375?page=comments#action_12329885 ]
Nathan Bubna commented on VELOCITY-375: --------------------------------------- thanks, Henning. this should help. of course, I don't like the addition of StringUtils (thus commons-lang) to core VelocityTools classes, especially just to check for an emptry string. i'll be undoing that change. :) also, i don't understand either the need for or accomplishment of your changes to the DataInfo class. from glancing over the patch, it looks like just another way to skin the same cat. can you explain that better? other than that, this looks pretty good, and i'll probably commit it mostly as is. > bad errors description > ---------------------- > > Key: VELOCITY-375 > URL: http://issues.apache.org/jira/browse/VELOCITY-375 > Project: Velocity > Type: Improvement > Components: Tools > Versions: 1.1 > Environment: Operating System: All > Platform: All > Reporter: Stepan Koltsov > Priority: Minor > Fix For: Tools-1.2 > Attachments: velocity-tools.patch > > Hello, > I've created toolbox.xml like this: > <toolbox><tool/></toolbox> > (yes, empty <tool/> tag). I got exception > java.lang.NullPointerException > org.apache.velocity.tools.view.ViewToolInfo.getInstance(ViewToolInfo.java:115) > org.apache.velocity.tools.view.servlet.ServletToolboxManager.getToolboxContext(ServletToolboxManager.java:354) > org.springframework.web.servlet.view.velocity.VelocityToolboxView.createVelocityContext(VelocityToolboxView.java:106) > ... > Yes, I know, it's my fault, but I think that errors in toolbox.xml should be > 1. Not fatal; > 2. Should be better explained. > I used velocity-tools-1.1. > And also I have a request -- could you please compile velocity-tools with > debugging info? I had to compile velocity-tools by myself to find error. (I > did > this before I've looked at my toolbox.xml :-) > Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
