[ http://issues.apache.org/jira/browse/VELOCITY-375?page=comments#action_12329901 ]
Henning Schmiedehausen commented on VELOCITY-375: ------------------------------------------------- Ah, come on. :-) commons-lang _is_ already a dependency of velocity-tools. We should try to keep the "uh, using a library method is bad, let's roll our own" reflex at bay. If commons-lang hasn't already been a dependency of velocity-tools (and the velocity-core), I wouldn't have introduced it. As it was, I didn't think too much about it. Do you think that is a problem? I could easily change the StringUtils.isEmpty() method call. > bad errors description > ---------------------- > > Key: VELOCITY-375 > URL: http://issues.apache.org/jira/browse/VELOCITY-375 > Project: Velocity > Type: Improvement > Components: Tools > Versions: 1.1 > Environment: Operating System: All > Platform: All > Reporter: Stepan Koltsov > Priority: Minor > Fix For: Tools-1.2 > Attachments: velocity-tools.patch > > Hello, > I've created toolbox.xml like this: > <toolbox><tool/></toolbox> > (yes, empty <tool/> tag). I got exception > java.lang.NullPointerException > org.apache.velocity.tools.view.ViewToolInfo.getInstance(ViewToolInfo.java:115) > org.apache.velocity.tools.view.servlet.ServletToolboxManager.getToolboxContext(ServletToolboxManager.java:354) > org.springframework.web.servlet.view.velocity.VelocityToolboxView.createVelocityContext(VelocityToolboxView.java:106) > ... > Yes, I know, it's my fault, but I think that errors in toolbox.xml should be > 1. Not fatal; > 2. Should be better explained. > I used velocity-tools-1.1. > And also I have a request -- could you please compile velocity-tools with > debugging info? I had to compile velocity-tools by myself to find error. (I > did > this before I've looked at my toolbox.xml :-) > Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
