Daniel Rall <[EMAIL PROTECTED]> writes:

>Henning, have you seen a spot where it would be reasonable to pass in the
>directory base name as some sort of configuration parameter?  Seems odd to
>leave it hard-coded like this.

Well, we can extend all the test cases from BaseTestCase and set it
there. However, these are just unit tests which are run in a
controlled environment and they work both ant and maven driven.

Any particular reason to change it further? 

        Best regards
                Henning



>- Dan

>On Sun, 25 Sep 2005, [EMAIL PROTECTED] wrote:

>> Author: henning
>> Date: Sun Sep 25 07:03:20 2005
>> New Revision: 291413
>> 
>> URL: http://svn.apache.org/viewcvs?rev=291413&view=rev
>> Log:
>> Test results should end up in target/test, not in the source tree.
>> 
>> Modified:
>>     
>> jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java
>> 
>> Modified: 
>> jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java
>> URL: 
>> http://svn.apache.org/viewcvs/jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java?rev=291413&r1=291412&r2=291413&view=diff
>> ==============================================================================
>> --- 
>> jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java
>>  (original)
>> +++ 
>> jakarta/velocity/core/trunk/src/test/org/apache/velocity/test/BuiltInEventHandlerTestCase.java
>>  Sun Sep 25 07:03:20 2005
>> @@ -70,7 +70,7 @@
>>     /**
>>      * Results relative to the build directory.
>>      */
>> -   private static final String RESULTS_DIR = "test/includeevent/results";
>> +   private static final String RESULTS_DIR = "target/test/includeevent";
>>  
>>     /**
>>      * Results relative to the build directory.
>> @@ -83,6 +83,11 @@
>>      public BuiltInEventHandlerTestCase(String name)
>>      {
>>          super(name);
>> +    }
>> +
>> +    public void setUp()
>> +    {
>> +        assureResultsDirectoryExists(RESULTS_DIR);
>>      }
>>  
>>      public static Test suite()
>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]

>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
[EMAIL PROTECTED]        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

                      4 - 8 - 15 - 16 - 23 - 42

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to