Hi Mark,
I was playing around with VM trying to figure out my reported problem
with Marking messages matching a subject or author which marks too
many things and was trying to confirm which git commit I was running.

I found that 'vm-version-commit' (Thanks for the rename!) was broken.
It still assumed you had the info in 'version.txt' on the 2nd line,
instead of it's own 'commit.txt' file.  So here's a patch to fix this.

But I think this version.txt and commit.txt is actually pretty damn
clunky.  Wouldn't it be better to have a 'vm-version-info.el' file
which just has:

      (defconst vm-version "8.3.x")
      (defconst vm-version-commit "abcde....12345")

instead, and this just gets loaded in startup?  It would be easy
enough to auto-generate this file during the buil process.  

Anyway, my simple patch:

diff --git i/lisp/vm-version.el w/lisp/vm-version.el
index 0fece92..1ab8ae4 100644
--- i/lisp/vm-version.el
+++ w/lisp/vm-version.el
@@ -55,8 +55,8 @@ Returns \"undefined\" if the file cannot be read."
     (message "VM version is: %s" vm-version))
   vm-version)
 
-(defconst vm-version-commit (vm-read-version-file "version.txt" 2)
-  "git commit number of VM.")
+(defconst vm-version-commit (vm-read-version-file "commit.txt" 1)
+  "git commit number of VM found in commit.txt of vm installation path.")
 
 (defun vm-version-commit ()
   "Return the value of the variable `vm-version-commit'."

Reply via email to