On Sun, 10 Oct 2010, Guilhem Bonnefille wrote:
> As I consider that this part of viking needs some redesign, I stay on
> a bypass solution for 1.0.
> Here is a simpler version of my patch.
Hi,
can you please apply the patch below. With your patch we only trigger an
autodownload when starting panning. And panning with keyboard shortcuts
doesn't work after pannung with the mouse.
Thanks,
Sven
>From 35aa8d36844e9025ea65c0d7e8fee32653b051f9 Mon Sep 17 00:00:00 2001
From: Sven Wegener <sven.wege...@stealer.net>
Date: Thu, 14 Oct 2010 21:46:11 +0200
Subject: [PATCH] Fix autodownloading while panning
Since commit 1c6a6010 ("Disable autodownloading when dragging the map")
we only trigger an autodownload when starting to pan and not on stop,
which is pretty bad. Also pan_move is never reset, resulting in no
update when panning with keyboard shortcuts after panning with the
mouse.
Signed-off-by: Sven Wegener <sven.wege...@stealer.net>
---
src/vikwindow.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/vikwindow.c b/src/vikwindow.c
index 8a37307..95ad1bf 100644
--- a/src/vikwindow.c
+++ b/src/vikwindow.c
@@ -506,10 +506,10 @@ static void vik_window_pan_move (VikWindow *vw,
GdkEventMotion *event)
if ( vw->pan_x != -1 ) {
vik_viewport_set_center_screen ( vw->viking_vvp,
vik_viewport_get_width(vw->viking_vvp)/2 - event->x + vw->pan_x,
vik_viewport_get_height(vw->viking_vvp)/2
- event->y + vw->pan_y );
- draw_update ( vw );
vw->pan_move = TRUE;
vw->pan_x = event->x;
vw->pan_y = event->y;
+ draw_update ( vw );
}
}
@@ -576,8 +576,9 @@ static void vik_window_pan_release ( VikWindow *vw,
GdkEventButton *event )
else
vik_viewport_set_center_screen ( vw->viking_vvp,
vik_viewport_get_width(vw->viking_vvp)/2 - event->x + vw->pan_x,
vik_viewport_get_height(vw->viking_vvp)/2 - event->y + vw->pan_y );
- draw_update ( vw );
+ vw->pan_move = FALSE;
vw->pan_x = vw->pan_y = -1;
+ draw_update ( vw );
}
static void draw_release ( VikWindow *vw, GdkEventButton *event )
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/
