Jonathan Smith wrote:

> >> Conary [1] has a file format called a "recipe" [2] which is in many
> >> ways similar in function to a spec file or an ebuild. rPath has been
> >> maintaining a syntax highlighting file for this format, but it would
> >> be nice if vim would accept a patch to include this in the standard
> >> distribution. Attached is just such a patch.
> > 
> > Thanks for looking into this.
> > 
> > "recipe" is not a good filetype name.  Is there anything against using
> > "conary"?
> > 
> > The syntax file must not start with "syntax clear".  Look into a few
> > examples in the Vim 7 distribution how this is done properly.
> > 
> > I would very much prefer that the author of the file directly sends the
> > syntax file to me.  At least for copyright issues.
> > 
> 
> Well, the files are called recipes. In the same way that you wouldn't call a 
> spec file "rpm", you wouldn't call a recipe "conary". Conary has other file 
> types which it uses, which vim should not be able to edit (changesets, the 
> equivalent of an RPM).

Well, then we would need to call it "conaryrecipe", but that's quite
long.

At least you need to be consistent: the name of the filetype is used for
the file name, and all syntax items must start with that name.

I now notice that you also have items starting with "python".  That's
weird.  Is this the result of copy&paste or was this intentional?

> You'll notice that "rPath Inc" is listed as the author. I am a member
> of the rPath distro team, and an employee of the same, so copyright
> shouldn't be an issue.

Ah, it's good to know this.

> Thanks for the tips about "syntax clear". Taking an example from the
> spec.vim file, I have modified the recipe.vim file to hopefully be
> acceptable. It is once again attached to this email.

Getting better.  Nikola's comments also apply (thanks Nikola!).

-- 
Sometimes you can protect millions of dollars in your budget simply by buying
a bag of cookies, dropping it on the budget anylyst's desk, and saying
something deeply personal such as "How was your weekend, big guy?"
                                (Scott Adams - The Dilbert principle)

 /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Reply via email to