Hi, On Sat, Aug 1, 2009 at 10:45 PM, björn<[email protected]> wrote: > A few comments on this patch: > > 1. Why have you not included the code that handles block-wise copy in > clip_mch_request_selection() from the MacVim sources? This is a bad > idea since it means that every time you copy from Vim the pasteboard > will only keep a "line-wise" copy. E.g. if you enter visual block > mode, copy, then paste, the text will be pasted line-wise even though > it should be pasted block-wise. Why did you "derive" the clipboard > code from MacVim instead of just copying it?
Because that code was included in vim-cocoa long time ago, you are right, I should have checked the recent MacVim code before send out this patch. > 2. I'm not decided on this myself, but maybe it would be cleaner to > implement this using the Carbon Pasteboard Manager instead of using > Cocoa (so that you don't have to use the Objective-C compiler, fiddle > around with autorelease pools, link against Cocoa etc.): > > http://developer.apple.com/documentation/Carbon/Reference/Pasteboard_Reference/Reference/reference.html I think Pasteboard Manager belongs to the part of Carbon that won't have 64-bit version. So it will prevent vim to be built as a 64-bit binary in future Mac OS X releases. > At any rate, I would not merge this patch until #1 is resolved. The > second issue is more delicate but I have myself implemented copy/paste > using Pasteboard Manager once and I know that it is not that much of > an effort, but then again the current MacVim clipboard code works and > has been in use for quite some time so it is maybe a better idea to > just include it verbatim. I agree. Would you like me to update this patch or maybe you prefer to separate that part of the code in MacVim as one patch yourself? - Jiang --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
