2009/8/1 Jjgod Jiang: > > On Sat, Aug 1, 2009 at 10:45 PM, björn<[email protected]> wrote: >> A few comments on this patch: >> >> 1. Why have you not included the code that handles block-wise copy in >> clip_mch_request_selection() from the MacVim sources? This is a bad >> idea since it means that every time you copy from Vim the pasteboard >> will only keep a "line-wise" copy. E.g. if you enter visual block >> mode, copy, then paste, the text will be pasted line-wise even though >> it should be pasted block-wise. Why did you "derive" the clipboard >> code from MacVim instead of just copying it? > > Because that code was included in vim-cocoa long time ago, you are right, > I should have checked the recent MacVim code before send out this patch.
Ok. >> 2. I'm not decided on this myself, but maybe it would be cleaner to >> implement this using the Carbon Pasteboard Manager instead of using >> Cocoa (so that you don't have to use the Objective-C compiler, fiddle >> around with autorelease pools, link against Cocoa etc.): >> >> http://developer.apple.com/documentation/Carbon/Reference/Pasteboard_Reference/Reference/reference.html > > I think Pasteboard Manager belongs to the part of Carbon that won't > have 64-bit version. So it will prevent vim to be built as a 64-bit > binary in future Mac OS X releases. Can you back that statement up? Looking at the docs I cannot see any warning about it not being available for 64 bit. Also, have you checked how much of an overhead in binary sizes it is building with obj-c and linking against Cocoa? (I assume it should not make much of a difference but it would be nice to know for sure. If the binary size increases significantly then I definitely think it would be advisable to use Pasteboard Manager.) Also, have you made sure that all the APIs used are present in OS X 10.0? For MacVim I only check 10.4 compatibility but since this patch is to os_macosx.c it should work on 10.0 and upwards. >> At any rate, I would not merge this patch until #1 is resolved. The >> second issue is more delicate but I have myself implemented copy/paste >> using Pasteboard Manager once and I know that it is not that much of >> an effort, but then again the current MacVim clipboard code works and >> has been in use for quite some time so it is maybe a better idea to >> just include it verbatim. > > I agree. Would you like me to update this patch or maybe you prefer to > separate that part of the code in MacVim as one patch yourself? Maybe the best idea would be if you submit this patch against both the MacVim sources and the Vim sources. I can merge the patch immediately and then Bram can merge the corresponding patch into the Vim sources after we've tested it out for a while and checked that everything is ok. I think its good that you're taking the time to fix this...I was hoping that somebody would. Thanks, Björn --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
