> While watching the compile, I suddenly notice that -D_FORTIFY_SOURCE=1
> appears three times in succession, in both my "Huge" version and my
> "Tiny" version. This is of course not a problem, but it "looks strange".
>
> Here are the "Compilation" lines as pasted from the ":version" or
> --version output:
>
> Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
> -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
> -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1
> -I/usr/include/freetype2 -I/usr/include/libpng12 -DORBIT2=1 -pthread
> -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0
> -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1
> -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0
> -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0
> -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
> -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0
> -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0
> -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2
> -I/usr/include/pango-1.0 -I/usr/include/gail-1.0
> -I/usr/include/freetype2 -I/usr/include/atk-1.0
> -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1
> -I/usr/include/libpng12 -O2 -fno-strength-reduce -Wall
> -D_FORTIFY_SOURCE=1 -D_FORTIFY_SOURCE=1 -D_FORTIFY_SOURCE=1
> -D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -DDEBUGGING
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -I/usr/lib/perl5/5.10.0/i586-linux-thread-multi/CORE
> -I/usr/include/python2.6 -pthread -I/usr/include
> -D_LARGEFILE64_SOURCE=1 -I/usr/lib/ruby/1.8/i586-linux
>
> Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2
> -fno-strength-reduce -Wall -D_FORTIFY_SOURCE=1 -D_FORTIFY_SOURCE=1
> -D_FORTIFY_SOURCE=1
>
>
> Best regards,
> Tony.
Hi Tony
I don't see this buglet on my machine. -D_FORTIFY_SOURCE=1
appears just once here.
Anyway, the attached patch should probably fix it.
Can you try it? You'll need to recreate the "configure" script
with autoconf. Example:
$ cd vim7/src
$ autoconf
$ ./configure --with-feature=huge
$ make
Cheers
-- Dominique
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
Index: configure.in
===================================================================
RCS file: /cvsroot/vim/vim7/src/configure.in,v
retrieving revision 1.77
diff -c -r1.77 configure.in
*** configure.in 17 Nov 2009 16:12:49 -0000 1.77
--- configure.in 25 Nov 2009 22:00:47 -0000
***************
*** 2557,2567 ****
AC_MSG_RESULT([pty mode: $vim_cv_tty_mode, group: $vim_cv_tty_group])
else
vim_cv_tty_group=world
! AC_MSG_RESULT([ptys are world accessable])
fi
],[
vim_cv_tty_group=world
! AC_MSG_RESULT([can't determine - assume ptys are world accessable])
],[
AC_MSG_ERROR(cross-compiling: please set 'vim_cv_tty_group' and 'vim_cv_tty_mode')
])
--- 2557,2567 ----
AC_MSG_RESULT([pty mode: $vim_cv_tty_mode, group: $vim_cv_tty_group])
else
vim_cv_tty_group=world
! AC_MSG_RESULT([ptys are world accessible])
fi
],[
vim_cv_tty_group=world
! AC_MSG_RESULT([can't determine - assume ptys are world accessible])
],[
AC_MSG_ERROR(cross-compiling: please set 'vim_cv_tty_group' and 'vim_cv_tty_mode')
])
***************
*** 3243,3249 ****
dnl declared as char x[1] but actually longer. Introduced in gcc 4.0.
AC_MSG_CHECKING(whether we need -D_FORTIFY_SOURCE=1)
if test "$gccmajor" -gt "3"; then
! CFLAGS=`echo "$CFLAGS -D_FORTIFY_SOURCE=1" | sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//g' -e 's/-D_FORTIFY_SOURCE=2//g'`
AC_MSG_RESULT(yes)
else
AC_MSG_RESULT(no)
--- 3243,3251 ----
dnl declared as char x[1] but actually longer. Introduced in gcc 4.0.
AC_MSG_CHECKING(whether we need -D_FORTIFY_SOURCE=1)
if test "$gccmajor" -gt "3"; then
! CFLAGS=`echo "$CFLAGS" | sed -e 's/-Wp,-D_FORTIFY_SOURCE=.//g' \
! -e 's/-D_FORTIFY_SOURCE=.//g' \
! -e 's/$/ -D_FORTIFY_SOURCE=1/'`
AC_MSG_RESULT(yes)
else
AC_MSG_RESULT(no)
