On 25/11/09 23:10, Dominique Pellé wrote:
>> While watching the compile, I suddenly notice that -D_FORTIFY_SOURCE=1
>> appears three times in succession, in both my "Huge" version and my
>> "Tiny" version. This is of course not a problem, but it "looks strange".
>>
>> Here are the "Compilation" lines as pasted from the ":version" or
>> --version output:
>>
>> Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
>> -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
>> -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
>> -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1
>> -I/usr/include/freetype2 -I/usr/include/libpng12   -DORBIT2=1 -pthread
>> -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0
>> -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1
>> -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0
>> -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0
>> -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
>> -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0
>> -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
>> -I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0
>> -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2
>> -I/usr/include/pango-1.0 -I/usr/include/gail-1.0
>> -I/usr/include/freetype2 -I/usr/include/atk-1.0
>> -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1
>> -I/usr/include/libpng12     -O2 -fno-strength-reduce -Wall
>> -D_FORTIFY_SOURCE=1 -D_FORTIFY_SOURCE=1 -D_FORTIFY_SOURCE=1
>> -D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -DDEBUGGING
>> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
>> -I/usr/lib/perl5/5.10.0/i586-linux-thread-multi/CORE
>> -I/usr/include/python2.6 -pthread -I/usr/include
>> -D_LARGEFILE64_SOURCE=1  -I/usr/lib/ruby/1.8/i586-linux
>>
>> Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O2
>> -fno-strength-reduce -Wall -D_FORTIFY_SOURCE=1 -D_FORTIFY_SOURCE=1
>> -D_FORTIFY_SOURCE=1
>>
>>
>> Best regards,
>> Tony.
>
> Hi Tony
>
> I don't see this buglet on my machine.  -D_FORTIFY_SOURCE=1
> appears just once here.
>
> Anyway, the attached patch should probably fix it.
>
> Can you try it? You'll need to recreate the "configure" script
> with autoconf.  Example:
>
> $ cd vim7/src
> $ autoconf
> $ ./configure --with-feature=huge
> $ make
>
> Cheers
> -- Dominique

Must be something I did at some point in the past. Before applying your 
patch, I tried "make reconfig" and the problem went away.

Here are my config arguments and compile lines now:

Tiny build (built in a shadow directory):

export CONF_OPT_X='--without-x'
export CONF_OPT_GUI='--disable-gui'
export CONF_OPT_FEAT='--with-features=tiny'
export CONF_OPT_PERL='--disable-perlinterp'
export CONF_OPT_PYTHON='--disable-pythoninterp'
export CONF_OPT_TCL='--disable-tclinterp'
export CONF_OPT_RUBY='--disable-rubyinterp'
export CONF_OPT_MZSCHEME='--disable-mzschemeinterp'
export CONF_OPT_CSCOPE='--disable-cscope'
export CONF_OPT_MULTIBYTE='--disable-multibyte'
export CONF_OPT_COMPBY='"[email protected]"'
export CONF_OPT_NETBEANS='--disable-netbeans'
export CONF_OPT_NLS='--disable-nls'
export CONF_OPT_ACL='--disable-acl'
export CONF_OPT_GPM='--disable-gpm'
export CONF_OPT_SYSMOUSE='--disable-sysmouse'
export CONF_ARGS='--with-vim-name=vi'

gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O2 -fno-strength-reduce -Wall 
-D_FORTIFY_SOURCE=1


Huge build:

export CONF_OPT_GUI='--enable-gnome-check'
export CONF_OPT_PERL='--enable-perlinterp'
export CONF_OPT_PYTHON='--enable-pythoninterp'
#export CONF_OPT_TCL='--enable-tclinterp --with-tclsh=tclsh8.5'
export CONF_OPT_TCL='--enable-tclinterp'
export CONF_OPT_RUBY='--enable-rubyinterp'
export CONF_OPT_MZSCHEME='--disable-mzschemeinterp'
#export CONF_OPT_PLTHOME='--with-plthome=/usr/local/plt'
export CONF_OPT_CSCOPE='--enable-cscope'
export CONF_OPT_MULTIBYTE='--enable-multibyte'
export CONF_OPT_FEAT='--with-features=huge'
export CONF_OPT_COMPBY='"[email protected]"'
#
# need to patch feature.h
# to disable +tag_old_static: comment out:
# # define FEAT_TAG_OLDSTATIC
# at line 360 (or about)
# to enable +xterm_save: uncomment:
# /* #define FEAT_XTERM_SAVE */
# at line 831 (or about)
#
export CONF_ARGS=''

gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK 
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 
-I/usr/include/freetype2 -I/usr/include/libpng12   -DORBIT2=1 -pthread 
-I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 
-I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1 
-I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0 
-I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0 
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include 
-I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 
-I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0 
-I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 
-I/usr/include/pango-1.0 -I/usr/include/gail-1.0 
-I/usr/include/freetype2 -I/usr/include/atk-1.0 
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 
-I/usr/include/libpng12     -O2 -fno-strength-reduce -Wall 
-D_FORTIFY_SOURCE=1    -D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV 
-DDEBUGGING  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 
-I/usr/lib/perl5/5.10.0/i586-linux-thread-multi/CORE 
-I/usr/include/python2.6 -pthread -I/usr/include 
-D_LARGEFILE64_SOURCE=1  -I/usr/lib/ruby/1.8/i586-linux



Best regards,
Tony.
-- 
I can't understand it.  I can't even understand the people who can
understand it.
                -- Queen Juliana of the Netherlands.

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Raspunde prin e-mail lui