Dominique Pelle wrote:
> > Why? Hmm, perhaps it's needed in charset.c, because towlower and
> > towupper are used there. I'll do that. Does it work now?
>
> I now understand why sizeof(off_t) was wrong. Vim did not compile
> with clang and I quickly added #include <wchar.h> to make it compile
> I included it *before* #include "auto/config.h" in Vim.h which was a
> mistake since auto/config.h #defines _FILE_OFFSET_BITS 64.
> Including <wchar.h> after "auto/config.h" makes sizeof(off_t) == 8
>
> Anyway, your recent changeset 2540:8a156630208b makes it compile
> and run without problem now with clang.
>
> I think #include <wchar.h> was needed to compile because with clang,
> I see this in auto/config.h:
>
> /* #undef HAVE_WCTYPE_H */
>
> Whereas with gcc, I see this:
>
> #define HAVE_WCTYPE_H 1
>
> Somehow, wctype.h header file does not compile!? (but that's not
> Vim's fault).
I'm glad there is a simple explanation and that it's fixed now.
> Another remark when using clang. I see several of this kind of compilation
> warnings which are easy to fix (see attached patch):
>
> ex_cmds.c:2083:18: warning: format string is not a string literal
> (potentially insecure) [-Wformat-security]
> fprintf(fp_out, _("# You may edit it if you're careful!\n\n"));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thanks, I'll include the patch.
--
hundred-and-one symptoms of being an internet addict:
48. You get a tatoo that says "This body best viewed with Netscape 3.1 or
higher."
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
