Similar approach is used in python’s dict.update.
# HG changeset patch
# User ZyX <[email protected]>
# Date 1369566559 -14400
# Node ID b5a15b33b9d26a9bb23088c31935616862d604c0
# Parent 44b8f018c4fc76aaeedd9424fc987ce31593fafb
Made pymap_to_tv use more standard PyMapping_Keys
diff -r 44b8f018c4fc -r b5a15b33b9d2 src/if_py_both.h
--- a/src/if_py_both.h Sun May 26 14:38:06 2013 +0400
+++ b/src/if_py_both.h Sun May 26 15:09:19 2013 +0400
@@ -4613,10 +4613,9 @@
char_u *key;
dictitem_T *di;
PyObject *list;
- PyObject *litem;
+ PyObject *iterator;
PyObject *keyObject;
PyObject *valObject;
- Py_ssize_t lsize;
if (!(dict = py_dict_alloc()))
return -1;
@@ -4624,61 +4623,52 @@
tv->v_type = VAR_DICT;
tv->vval.v_dict = dict;
- list = PyMapping_Items(obj);
- if (list == NULL)
+ if (!(list = PyMapping_Keys(obj)))
{
dict_unref(dict);
return -1;
}
- lsize = PyList_Size(list);
- while (lsize--)
+
+ if (!(iterator = PyObject_GetIter(list)))
+ {
+ dict_unref(dict);
+ Py_DECREF(list);
+ return -1;
+ }
+ Py_DECREF(list);
+
+ while ((keyObject = PyIter_Next(iterator)))
{
DICTKEY_DECL
- litem = PyList_GetItem(list, lsize);
- if (litem == NULL)
- {
- Py_DECREF(list);
- dict_unref(dict);
- return -1;
- }
-
- if (!(keyObject = PyTuple_GetItem(litem, 0)))
- {
- Py_DECREF(list);
- Py_DECREF(litem);
- dict_unref(dict);
- return -1;
- }
-
if (!DICTKEY_SET_KEY)
{
+ Py_DECREF(iterator);
dict_unref(dict);
- Py_DECREF(list);
- Py_DECREF(litem);
DICTKEY_UNREF
return -1;
}
DICTKEY_CHECK_EMPTY(-1)
- if (!(valObject = PyTuple_GetItem(litem, 1)))
+ if (!(valObject = PyObject_GetItem(obj, keyObject)))
{
- Py_DECREF(list);
- Py_DECREF(litem);
+ Py_DECREF(keyObject);
+ Py_DECREF(iterator);
dict_unref(dict);
DICTKEY_UNREF
return -1;
}
- Py_DECREF(litem);
-
di = dictitem_alloc(key);
DICTKEY_UNREF
+ Py_DECREF(keyObject);
+
if (di == NULL)
{
- Py_DECREF(list);
+ Py_DECREF(iterator);
+ Py_DECREF(valObject);
dict_unref(dict);
PyErr_NoMemory();
return -1;
@@ -4687,23 +4677,26 @@
if (_ConvertFromPyObject(valObject, &di->di_tv, lookup_dict) == -1)
{
+ Py_DECREF(iterator);
+ Py_DECREF(valObject);
vim_free(di);
dict_unref(dict);
- Py_DECREF(list);
return -1;
}
+ Py_DECREF(valObject);
+
if (dict_add(dict, di) == FAIL)
{
+ Py_DECREF(iterator);
dictitem_free(di);
dict_unref(dict);
- Py_DECREF(list);
PyErr_SetVim(_("failed to add key to dictionary"));
return -1;
}
}
+ Py_DECREF(iterator);
--dict->dv_refcount;
- Py_DECREF(list);
return 0;
}
@@ -4908,6 +4901,8 @@
tv->vval.v_float = (float_T) PyFloat_AsDouble(obj);
}
#endif
+ else if (PyObject_HasAttrString(obj, "keys"))
+ return convert_dl(obj, tv, pymap_to_tv, lookup_dict);
else if (PyIter_Check(obj) || PySequence_Check(obj))
return convert_dl(obj, tv, pyseq_to_tv, lookup_dict);
else if (PyMapping_Check(obj))
diff -r 44b8f018c4fc -r b5a15b33b9d2 src/if_python.c
--- a/src/if_python.c Sun May 26 14:38:06 2013 +0400
+++ b/src/if_python.c Sun May 26 15:09:19 2013 +0400
@@ -197,11 +197,12 @@
# define PyDict_GetItemString dll_PyDict_GetItemString
# define PyDict_Next dll_PyDict_Next
# define PyDict_Type (*dll_PyDict_Type)
-# ifdef PyMapping_Items
-# define PY_NO_MAPPING_ITEMS
+# ifdef PyMapping_Keys
+# define PY_NO_MAPPING_KEYS
# else
-# define PyMapping_Items dll_PyMapping_Items
+# define PyMapping_Keys dll_PyMapping_Keys
# endif
+# define PyObject_GetItem dll_PyObject_GetItem
# define PyObject_CallMethod dll_PyObject_CallMethod
# define PyMapping_Check dll_PyMapping_Check
# define PyIter_Next dll_PyIter_Next
@@ -331,9 +332,10 @@
static PyObject*(*dll_PyDict_GetItemString)(PyObject *, const char *);
static int (*dll_PyDict_Next)(PyObject *, PyInt *, PyObject **, PyObject **);
static PyTypeObject* dll_PyDict_Type;
-# ifndef PY_NO_MAPPING_ITEMS
-static PyObject* (*dll_PyMapping_Items)(PyObject *);
+# ifndef PY_NO_MAPPING_KEYS
+static PyObject* (*dll_PyMapping_Keys)(PyObject *);
# endif
+static PyObject* (*dll_PyObject_GetItem)(PyObject *, PyObject *);
static PyObject* (*dll_PyObject_CallMethod)(PyObject *, char *, PyObject *);
static int (*dll_PyMapping_Check)(PyObject *);
static PyObject* (*dll_PyIter_Next)(PyObject *);
@@ -494,9 +496,10 @@
{"PyDict_Next", (PYTHON_PROC*)&dll_PyDict_Next},
{"PyDict_New", (PYTHON_PROC*)&dll_PyDict_New},
{"PyDict_Type", (PYTHON_PROC*)&dll_PyDict_Type},
-# ifndef PY_NO_MAPPING_ITEMS
- {"PyMapping_Items", (PYTHON_PROC*)&dll_PyMapping_Items},
+# ifndef PY_NO_MAPPING_KEYS
+ {"PyMapping_Keys", (PYTHON_PROC*)&dll_PyMapping_Keys},
# endif
+ {"PyObject_GetItem", (PYTHON_PROC*)&dll_PyObject_GetItem},
{"PyObject_CallMethod", (PYTHON_PROC*)&dll_PyObject_CallMethod},
{"PyMapping_Check", (PYTHON_PROC*)&dll_PyMapping_Check},
{"PyIter_Next", (PYTHON_PROC*)&dll_PyIter_Next},
diff -r 44b8f018c4fc -r b5a15b33b9d2 src/if_python3.c
--- a/src/if_python3.c Sun May 26 14:38:06 2013 +0400
+++ b/src/if_python3.c Sun May 26 15:09:19 2013 +0400
@@ -160,9 +160,10 @@
# define PyDict_GetItemString py3_PyDict_GetItemString
# define PyDict_Next py3_PyDict_Next
# define PyMapping_Check py3_PyMapping_Check
-# define PyMapping_Items py3_PyMapping_Items
+# define PyMapping_Keys py3_PyMapping_Keys
# define PyIter_Next py3_PyIter_Next
# define PyObject_GetIter py3_PyObject_GetIter
+# define PyObject_GetItem py3_PyObject_GetItem
# define PyObject_IsTrue py3_PyObject_IsTrue
# define PyModule_GetDict py3_PyModule_GetDict
#undef PyRun_SimpleString
@@ -267,7 +268,7 @@
static Py_ssize_t (*py3_PyTuple_Size)(PyObject *);
static PyObject* (*py3_PyTuple_GetItem)(PyObject *, Py_ssize_t);
static int (*py3_PyMapping_Check)(PyObject *);
-static PyObject* (*py3_PyMapping_Items)(PyObject *);
+static PyObject* (*py3_PyMapping_Keys)(PyObject *);
static int (*py3_PySlice_GetIndicesEx)(PyObject *r, Py_ssize_t length,
Py_ssize_t *start, Py_ssize_t *stop, Py_ssize_t *step,
Py_ssize_t *slicelength);
static PyObject* (*py3_PyErr_NoMemory)(void);
@@ -295,6 +296,7 @@
static PyObject* (*py3_PyDict_New)(void);
static PyObject* (*py3_PyIter_Next)(PyObject *);
static PyObject* (*py3_PyObject_GetIter)(PyObject *);
+static PyObject* (*py3_PyObject_GetItem)(PyObject *, PyObject *);
static int (*py3_PyObject_IsTrue)(PyObject *);
static PyObject* (*py3_Py_BuildValue)(char *, ...);
static int (*py3_PyType_Ready)(PyTypeObject *type);
@@ -439,9 +441,10 @@
{"PyDict_GetItemString", (PYTHON_PROC*)&py3_PyDict_GetItemString},
{"PyDict_Next", (PYTHON_PROC*)&py3_PyDict_Next},
{"PyMapping_Check", (PYTHON_PROC*)&py3_PyMapping_Check},
- {"PyMapping_Items", (PYTHON_PROC*)&py3_PyMapping_Items},
+ {"PyMapping_Keys", (PYTHON_PROC*)&py3_PyMapping_Keys},
{"PyIter_Next", (PYTHON_PROC*)&py3_PyIter_Next},
{"PyObject_GetIter", (PYTHON_PROC*)&py3_PyObject_GetIter},
+ {"PyObject_GetItem", (PYTHON_PROC*)&py3_PyObject_GetItem},
{"PyObject_IsTrue", (PYTHON_PROC*)&py3_PyObject_IsTrue},
{"PyLong_FromLong", (PYTHON_PROC*)&py3_PyLong_FromLong},
{"PyDict_New", (PYTHON_PROC*)&py3_PyDict_New},
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
diff -cr vim.44b8f018c4fc/src/if_py_both.h vim.b5a15b33b9d2/src/if_py_both.h
*** vim.44b8f018c4fc/src/if_py_both.h 2013-05-26 16:25:19.886154350 +0400
--- vim.b5a15b33b9d2/src/if_py_both.h 2013-05-26 16:25:19.897154205 +0400
***************
*** 4613,4622 ****
char_u *key;
dictitem_T *di;
PyObject *list;
! PyObject *litem;
PyObject *keyObject;
PyObject *valObject;
- Py_ssize_t lsize;
if (!(dict = py_dict_alloc()))
return -1;
--- 4613,4621 ----
char_u *key;
dictitem_T *di;
PyObject *list;
! PyObject *iterator;
PyObject *keyObject;
PyObject *valObject;
if (!(dict = py_dict_alloc()))
return -1;
***************
*** 4624,4684 ****
tv->v_type = VAR_DICT;
tv->vval.v_dict = dict;
! list = PyMapping_Items(obj);
! if (list == NULL)
{
dict_unref(dict);
return -1;
}
- lsize = PyList_Size(list);
- while (lsize--)
- {
- DICTKEY_DECL
! litem = PyList_GetItem(list, lsize);
! if (litem == NULL)
! {
! Py_DECREF(list);
! dict_unref(dict);
! return -1;
! }
! if (!(keyObject = PyTuple_GetItem(litem, 0)))
! {
! Py_DECREF(list);
! Py_DECREF(litem);
! dict_unref(dict);
! return -1;
! }
if (!DICTKEY_SET_KEY)
{
dict_unref(dict);
- Py_DECREF(list);
- Py_DECREF(litem);
DICTKEY_UNREF
return -1;
}
DICTKEY_CHECK_EMPTY(-1)
! if (!(valObject = PyTuple_GetItem(litem, 1)))
{
! Py_DECREF(list);
! Py_DECREF(litem);
dict_unref(dict);
DICTKEY_UNREF
return -1;
}
- Py_DECREF(litem);
-
di = dictitem_alloc(key);
DICTKEY_UNREF
if (di == NULL)
{
! Py_DECREF(list);
dict_unref(dict);
PyErr_NoMemory();
return -1;
--- 4623,4674 ----
tv->v_type = VAR_DICT;
tv->vval.v_dict = dict;
! if (!(list = PyMapping_Keys(obj)))
{
dict_unref(dict);
return -1;
}
! if (!(iterator = PyObject_GetIter(list)))
! {
! dict_unref(dict);
! Py_DECREF(list);
! return -1;
! }
! Py_DECREF(list);
! while ((keyObject = PyIter_Next(iterator)))
! {
! DICTKEY_DECL
if (!DICTKEY_SET_KEY)
{
+ Py_DECREF(iterator);
dict_unref(dict);
DICTKEY_UNREF
return -1;
}
DICTKEY_CHECK_EMPTY(-1)
! if (!(valObject = PyObject_GetItem(obj, keyObject)))
{
! Py_DECREF(keyObject);
! Py_DECREF(iterator);
dict_unref(dict);
DICTKEY_UNREF
return -1;
}
di = dictitem_alloc(key);
DICTKEY_UNREF
+ Py_DECREF(keyObject);
+
if (di == NULL)
{
! Py_DECREF(iterator);
! Py_DECREF(valObject);
dict_unref(dict);
PyErr_NoMemory();
return -1;
***************
*** 4687,4709 ****
if (_ConvertFromPyObject(valObject, &di->di_tv, lookup_dict) == -1)
{
vim_free(di);
dict_unref(dict);
- Py_DECREF(list);
return -1;
}
if (dict_add(dict, di) == FAIL)
{
dictitem_free(di);
dict_unref(dict);
- Py_DECREF(list);
PyErr_SetVim(_("failed to add key to dictionary"));
return -1;
}
}
--dict->dv_refcount;
- Py_DECREF(list);
return 0;
}
--- 4677,4702 ----
if (_ConvertFromPyObject(valObject, &di->di_tv, lookup_dict) == -1)
{
+ Py_DECREF(iterator);
+ Py_DECREF(valObject);
vim_free(di);
dict_unref(dict);
return -1;
}
+ Py_DECREF(valObject);
+
if (dict_add(dict, di) == FAIL)
{
+ Py_DECREF(iterator);
dictitem_free(di);
dict_unref(dict);
PyErr_SetVim(_("failed to add key to dictionary"));
return -1;
}
}
+ Py_DECREF(iterator);
--dict->dv_refcount;
return 0;
}
***************
*** 4908,4913 ****
--- 4901,4908 ----
tv->vval.v_float = (float_T) PyFloat_AsDouble(obj);
}
#endif
+ else if (PyObject_HasAttrString(obj, "keys"))
+ return convert_dl(obj, tv, pymap_to_tv, lookup_dict);
else if (PyIter_Check(obj) || PySequence_Check(obj))
return convert_dl(obj, tv, pyseq_to_tv, lookup_dict);
else if (PyMapping_Check(obj))
diff -cr vim.44b8f018c4fc/src/if_python3.c vim.b5a15b33b9d2/src/if_python3.c
*** vim.44b8f018c4fc/src/if_python3.c 2013-05-26 16:25:19.881154415 +0400
--- vim.b5a15b33b9d2/src/if_python3.c 2013-05-26 16:25:19.893154260 +0400
***************
*** 160,168 ****
# define PyDict_GetItemString py3_PyDict_GetItemString
# define PyDict_Next py3_PyDict_Next
# define PyMapping_Check py3_PyMapping_Check
! # define PyMapping_Items py3_PyMapping_Items
# define PyIter_Next py3_PyIter_Next
# define PyObject_GetIter py3_PyObject_GetIter
# define PyObject_IsTrue py3_PyObject_IsTrue
# define PyModule_GetDict py3_PyModule_GetDict
#undef PyRun_SimpleString
--- 160,169 ----
# define PyDict_GetItemString py3_PyDict_GetItemString
# define PyDict_Next py3_PyDict_Next
# define PyMapping_Check py3_PyMapping_Check
! # define PyMapping_Keys py3_PyMapping_Keys
# define PyIter_Next py3_PyIter_Next
# define PyObject_GetIter py3_PyObject_GetIter
+ # define PyObject_GetItem py3_PyObject_GetItem
# define PyObject_IsTrue py3_PyObject_IsTrue
# define PyModule_GetDict py3_PyModule_GetDict
#undef PyRun_SimpleString
***************
*** 267,273 ****
static Py_ssize_t (*py3_PyTuple_Size)(PyObject *);
static PyObject* (*py3_PyTuple_GetItem)(PyObject *, Py_ssize_t);
static int (*py3_PyMapping_Check)(PyObject *);
! static PyObject* (*py3_PyMapping_Items)(PyObject *);
static int (*py3_PySlice_GetIndicesEx)(PyObject *r, Py_ssize_t length,
Py_ssize_t *start, Py_ssize_t *stop, Py_ssize_t *step, Py_ssize_t *slicelength);
static PyObject* (*py3_PyErr_NoMemory)(void);
--- 268,274 ----
static Py_ssize_t (*py3_PyTuple_Size)(PyObject *);
static PyObject* (*py3_PyTuple_GetItem)(PyObject *, Py_ssize_t);
static int (*py3_PyMapping_Check)(PyObject *);
! static PyObject* (*py3_PyMapping_Keys)(PyObject *);
static int (*py3_PySlice_GetIndicesEx)(PyObject *r, Py_ssize_t length,
Py_ssize_t *start, Py_ssize_t *stop, Py_ssize_t *step, Py_ssize_t *slicelength);
static PyObject* (*py3_PyErr_NoMemory)(void);
***************
*** 295,300 ****
--- 296,302 ----
static PyObject* (*py3_PyDict_New)(void);
static PyObject* (*py3_PyIter_Next)(PyObject *);
static PyObject* (*py3_PyObject_GetIter)(PyObject *);
+ static PyObject* (*py3_PyObject_GetItem)(PyObject *, PyObject *);
static int (*py3_PyObject_IsTrue)(PyObject *);
static PyObject* (*py3_Py_BuildValue)(char *, ...);
static int (*py3_PyType_Ready)(PyTypeObject *type);
***************
*** 439,447 ****
{"PyDict_GetItemString", (PYTHON_PROC*)&py3_PyDict_GetItemString},
{"PyDict_Next", (PYTHON_PROC*)&py3_PyDict_Next},
{"PyMapping_Check", (PYTHON_PROC*)&py3_PyMapping_Check},
! {"PyMapping_Items", (PYTHON_PROC*)&py3_PyMapping_Items},
{"PyIter_Next", (PYTHON_PROC*)&py3_PyIter_Next},
{"PyObject_GetIter", (PYTHON_PROC*)&py3_PyObject_GetIter},
{"PyObject_IsTrue", (PYTHON_PROC*)&py3_PyObject_IsTrue},
{"PyLong_FromLong", (PYTHON_PROC*)&py3_PyLong_FromLong},
{"PyDict_New", (PYTHON_PROC*)&py3_PyDict_New},
--- 441,450 ----
{"PyDict_GetItemString", (PYTHON_PROC*)&py3_PyDict_GetItemString},
{"PyDict_Next", (PYTHON_PROC*)&py3_PyDict_Next},
{"PyMapping_Check", (PYTHON_PROC*)&py3_PyMapping_Check},
! {"PyMapping_Keys", (PYTHON_PROC*)&py3_PyMapping_Keys},
{"PyIter_Next", (PYTHON_PROC*)&py3_PyIter_Next},
{"PyObject_GetIter", (PYTHON_PROC*)&py3_PyObject_GetIter},
+ {"PyObject_GetItem", (PYTHON_PROC*)&py3_PyObject_GetItem},
{"PyObject_IsTrue", (PYTHON_PROC*)&py3_PyObject_IsTrue},
{"PyLong_FromLong", (PYTHON_PROC*)&py3_PyLong_FromLong},
{"PyDict_New", (PYTHON_PROC*)&py3_PyDict_New},
diff -cr vim.44b8f018c4fc/src/if_python.c vim.b5a15b33b9d2/src/if_python.c
*** vim.44b8f018c4fc/src/if_python.c 2013-05-26 16:25:19.889154309 +0400
--- vim.b5a15b33b9d2/src/if_python.c 2013-05-26 16:25:19.900154168 +0400
***************
*** 197,207 ****
# define PyDict_GetItemString dll_PyDict_GetItemString
# define PyDict_Next dll_PyDict_Next
# define PyDict_Type (*dll_PyDict_Type)
! # ifdef PyMapping_Items
! # define PY_NO_MAPPING_ITEMS
# else
! # define PyMapping_Items dll_PyMapping_Items
# endif
# define PyObject_CallMethod dll_PyObject_CallMethod
# define PyMapping_Check dll_PyMapping_Check
# define PyIter_Next dll_PyIter_Next
--- 197,208 ----
# define PyDict_GetItemString dll_PyDict_GetItemString
# define PyDict_Next dll_PyDict_Next
# define PyDict_Type (*dll_PyDict_Type)
! # ifdef PyMapping_Keys
! # define PY_NO_MAPPING_KEYS
# else
! # define PyMapping_Keys dll_PyMapping_Keys
# endif
+ # define PyObject_GetItem dll_PyObject_GetItem
# define PyObject_CallMethod dll_PyObject_CallMethod
# define PyMapping_Check dll_PyMapping_Check
# define PyIter_Next dll_PyIter_Next
***************
*** 331,339 ****
static PyObject*(*dll_PyDict_GetItemString)(PyObject *, const char *);
static int (*dll_PyDict_Next)(PyObject *, PyInt *, PyObject **, PyObject **);
static PyTypeObject* dll_PyDict_Type;
! # ifndef PY_NO_MAPPING_ITEMS
! static PyObject* (*dll_PyMapping_Items)(PyObject *);
# endif
static PyObject* (*dll_PyObject_CallMethod)(PyObject *, char *, PyObject *);
static int (*dll_PyMapping_Check)(PyObject *);
static PyObject* (*dll_PyIter_Next)(PyObject *);
--- 332,341 ----
static PyObject*(*dll_PyDict_GetItemString)(PyObject *, const char *);
static int (*dll_PyDict_Next)(PyObject *, PyInt *, PyObject **, PyObject **);
static PyTypeObject* dll_PyDict_Type;
! # ifndef PY_NO_MAPPING_KEYS
! static PyObject* (*dll_PyMapping_Keys)(PyObject *);
# endif
+ static PyObject* (*dll_PyObject_GetItem)(PyObject *, PyObject *);
static PyObject* (*dll_PyObject_CallMethod)(PyObject *, char *, PyObject *);
static int (*dll_PyMapping_Check)(PyObject *);
static PyObject* (*dll_PyIter_Next)(PyObject *);
***************
*** 494,502 ****
{"PyDict_Next", (PYTHON_PROC*)&dll_PyDict_Next},
{"PyDict_New", (PYTHON_PROC*)&dll_PyDict_New},
{"PyDict_Type", (PYTHON_PROC*)&dll_PyDict_Type},
! # ifndef PY_NO_MAPPING_ITEMS
! {"PyMapping_Items", (PYTHON_PROC*)&dll_PyMapping_Items},
# endif
{"PyObject_CallMethod", (PYTHON_PROC*)&dll_PyObject_CallMethod},
{"PyMapping_Check", (PYTHON_PROC*)&dll_PyMapping_Check},
{"PyIter_Next", (PYTHON_PROC*)&dll_PyIter_Next},
--- 496,505 ----
{"PyDict_Next", (PYTHON_PROC*)&dll_PyDict_Next},
{"PyDict_New", (PYTHON_PROC*)&dll_PyDict_New},
{"PyDict_Type", (PYTHON_PROC*)&dll_PyDict_Type},
! # ifndef PY_NO_MAPPING_KEYS
! {"PyMapping_Keys", (PYTHON_PROC*)&dll_PyMapping_Keys},
# endif
+ {"PyObject_GetItem", (PYTHON_PROC*)&dll_PyObject_GetItem},
{"PyObject_CallMethod", (PYTHON_PROC*)&dll_PyObject_CallMethod},
{"PyMapping_Check", (PYTHON_PROC*)&dll_PyMapping_Check},
{"PyIter_Next", (PYTHON_PROC*)&dll_PyIter_Next},
