Raymond Ko wrote:
> On Wednesday, February 4, 2015 at 4:03:09 PM UTC-5, Bram Moolenaar wrote:
> > Patch 7.4.619 (after 7.4.618)
> > Problem: luaV_setref() not returning the correct value.
> > Solution: Return one.
> > Files: src/if_lua.c
> >
> >
> > *** ../vim-7.4.618/src/if_lua.c 2015-02-03 23:10:41.574348921 +0100
> > --- src/if_lua.c 2015-02-04 22:01:19.649852981 +0100
> > ***************
> > *** 1517,1523 ****
> > return 0;
> > }
> > luaV_totypval(L, -1, rettv);
> > ! return 0;
> > }
> >
> > static int
> > --- 1517,1523 ----
> > return 0;
> > }
> > luaV_totypval(L, -1, rettv);
> > ! return 1;
> > }
> >
> > static int
> > ***************
> > *** 1530,1536 ****
> > luaV_getfield(L, LUAVIM_LIST);
> > luaV_getfield(L, LUAVIM_DICT);
> > lua_pushnil(L);
> > ! while (!abort && lua_next(L, lua_upvalueindex(1)) != 0) /* traverse
> > cache table */
> > {
> > lua_getmetatable(L, -1);
> > if (lua_rawequal(L, -1, 2)) /* list? */
> > --- 1530,1537 ----
> > luaV_getfield(L, LUAVIM_LIST);
> > luaV_getfield(L, LUAVIM_DICT);
> > lua_pushnil(L);
> > ! /* traverse cache table */
> > ! while (!abort && lua_next(L, lua_upvalueindex(1)) != 0)
> > {
> > lua_getmetatable(L, -1);
> > if (lua_rawequal(L, -1, 2)) /* list? */
> > *** ../vim-7.4.618/src/version.c 2015-02-03 23:10:41.574348921 +0100
> > --- src/version.c 2015-02-04 22:02:02.317286761 +0100
> > ***************
> > *** 743,744 ****
> > --- 743,746 ----
> > { /* Add new patch number below this line */
> > + /**/
> > + 619,
> > /**/
> >
> > --
> > I'm so disorganized my keyboard isn't even in alphabetical order!
> >
> > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
> > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
> > \\\ an exciting new programming language -- http://www.Zimbu.org ///
> > \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
>
> Should the the change to return 1 be in the luaV_setref() function
> instead of the luaV_eval() function? I think the change is in the
> wrong place.
Oops! That's what happens when there is no test.
--
hundred-and-one symptoms of being an internet addict:
176. You lie, even to user-friends, about how long you were online yesterday.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.