$ make clean all && ./blowfish
gcc -Wall -g -O2  -o blowfish.o -c blowfish.c
gcc -Wall -g -O2  -o common.o -c common.c
gcc -Wall -g -O2  -o main.o -c main.c
gcc -Wall -g -O2  -o sha256.o -c sha256.c
gcc -o blowfish blowfish.o common.o main.o sha256.o
E819: Blowfish test failed
bf_self_test() returned 0

$ perl -pi -e 's/(bfs->sbx)(.*)(sbx_init)/$3$2$1/' blowfish.c
$ make clean all && ./blowfish
gcc -Wall -g -O2  -o blowfish.o -c blowfish.c
gcc -Wall -g -O2  -o common.o -c common.c
gcc -Wall -g -O2  -o main.o -c main.c
gcc -Wall -g -O2  -o sha256.o -c sha256.c
gcc -o blowfish blowfish.o common.o main.o sha256.o
COIN: test successed
bf_self_test() returned 1


Good! Excellent! Thanks!

> In blowfish.c,
> 
> The args src and dest to mch_memmove reversed from
> the convention used by memmove,  so code is zeroing out sbx_init
> instead of initializing bfs->sbx
> 
> Reverse the src and dest in this line to fix the code.
> 
>    /* Use "key" to initialize the P-array ("pax") and S-boxes ("sbx") of
>      * Blowfish. */
>     mch_memmove(bfs->sbx, sbx_init, 4 * 4 * 256);
> 
> Please check that the latest vim source doesn't have this problem.
> In vim73, I was using a loop to init sbx, so this was not an issue.
> Difficult to catch but for the self_test.
> 
> thanks,

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui