I ran vim74 blowfish encryption in a debugger and vim74 blowfish is working correctly.
Yves had reversed the arguments (dst,src) to mch_memmove in his copy of the source common.c I wish, vim provided microsoft visual studio projects (dsp, dsw, sln) with the sources, then vim would debug-able without effort. On 4/13/15, Ben Fritz <[email protected]> wrote: > On Saturday, April 11, 2015 at 12:22:07 PM UTC-5, m wrote: >> In blowfish.c, >> >> The args src and dest to mch_memmove reversed from >> the convention used by memmove, so code is zeroing out sbx_init >> instead of initializing bfs->sbx >> >> Reverse the src and dest in this line to fix the code. >> >> /* Use "key" to initialize the P-array ("pax") and S-boxes ("sbx") of >> * Blowfish. */ >> mch_memmove(bfs->sbx, sbx_init, 4 * 4 * 256); >> >> Please check that the latest vim source doesn't have this problem. >> In vim73, I was using a loop to init sbx, so this was not an issue. >> Difficult to catch but for the self_test. >> > > Oh dear. Is a new blowfish3 needed? I do see this code in the 7.4.670, > though I do not know anything about whether this code is correct or not, so > I'm taking your word for that. > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
