On 8 September 2015, Tony Mechelynck <[email protected]> wrote:
> On Mon, Sep 7, 2015 at 8:14 PM, Christian Brabandt <[email protected]> wrote:
> > On Mo, 07 Sep 2015, LCD 47 wrote:
> >
> >> +NU ^@ 10 SH ^A 1 SX ^B 2 EX ^C 3 ET ^D 4 EQ ^E 5
> > [… digraph list]
> >
> > Isn't this list different on different systems? At least, IIRC, for
> > EBCDIC this would fail, wouldn't it? I am not sure, this matters
> > nowadays anymore.
> >
> > Also I would add some special cases when testing digraphs:
> > - Test, that <c-k><space>a returns the expected value (space is special)
> > - Test, that <c-k><S-Space> returns <S-Space> as described at :h
> > i_CTRL-K
> > (S-Space will probably hard to type in the test, as this will probably
> > only work reliable in the Gui, don't know what other chars are special
> > in that context, besides the one mentioned in the help).
> > so perhaps a test is not needed for that.
> > - Test, that <C-K>a: is the same as <C-K>:a (digraphs can usually be
> > entered in any order)
> > - Test, that <C-K>=e and <C-K>Eu return the Euro sign
> >
> > Also this bit from the help seems to be obsolete:
> >
> > ,----
> > | The <Esc> character cannot be part of a digraph. When hitting <Esc>, Vim
> > | stops digraph entry and ends Insert mode or Command-line mode, just like
> > | hitting an <Esc> out of digraph context.
> > `----
> >
> > It never ends Insert or Command line mode fore me, so this seems to be
> > wrong. And since no one complained about that until today, I think that
> > can be removed.
> >
> > Best,
> > Christian
> > --
> > 50% meines Werbebudgets ist hinausgeworfenes Geld. Niemand kann mir
> > allerdings sagen, welche 50% das sind.
> > -- Henry Ford
>
> For me (and with LCD47's first version of the patch in place),
[...]
For what it's worth, the part of the latest patch that "does
something" still consist of the same ~5 lines as the first version. The
other ~600 lines are me struggling (and mostly failing) to write tests
for digraphs. I suppose those particular tests could be useful for
coverage analysis and the like. Also, they would come in quite handy
~10 years from now, when the code dealing with digraphs is going to be
updated. :)
/lcd
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
