Lcd wrote: > > > On 8 September 2015, Christian Brabandt <[email protected]> wrote: > > > > On Di, 08 Sep 2015, LCD 47 wrote: > > > > > > > > > Yes, this finally seems to work. I suppose the patch below is the > > > > > final version then. > > > > > > > > Isn't there still something missing? > > > > > > > > - Still missing the update to the documentation, regarding esc > > > > - Tests for some special <c-k> cases like this one: > > > > - <c-k>a<esc>cw > > > > > > Does this have anything to do with my initial patch? I'm afraid > > > I don't understand either the intended behaviour here, or how to > > > test it. > > > > > > > - <c-k><space>a > > > > - <c-k>a: and <c-k>:a > > > > > > I believe these are part of the patch? > > > > > > > I think we can ignore the part about special casing certain keys > > > > as mentioned at :h i_CTRL-K That is not reliable testable. > > > > > > > > Personally, I wouldn't create digraphs.vim but use instead this > > > > line in the 2 testfile: > > > > > > > > :if !has("digraphs") | e! test.ok | w! test.out | qa! | endif > > > > > > > > But that is just my personal opinion. > > > > > > Ok, patch withdrawn. > > > > I don't think we should test all digraphs. Just testing a few will > > show that the mechanism works. Doing the whole table doesn't make > > sense, it will just duplicate the list into the tests. > > Sure, but the point was to test digraph listing functionality, > rather than the exact values. The fact that the values for some common > digraphs (f.i. simple accents) are also tested comes as a bonus. *shrug*
We don't want the test to break every time a digraph is added. > > For the number formats, I think we should only do decimal and hex. > > Octal (with leading zero) often confuses people. > > Using octal numbers for character codes becomes obvious once you > write the latin1 characters in 8x8 tables. :) Admittedly, that's not the > kind of things people tend to know these days though. Anyway, is there > a reason to disable octal values here while allowing them everywhere > else? Octal is recognized in a few places, and it does cause confusion. Not so many people use octal notation, and even fewer use it for multi-byte characters, it's more important to avoid the confusion. -- Bad programs can be written in any language. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
