2015-11-30 0:01 GMT+03:00 Bram Moolenaar <[email protected]>: > > Christian Brabandt wrote: > > > On So, 29 Nov 2015, Bram Moolenaar wrote: > > > > > > > > Nikolay Pavlov wrote: > > > > > > > 2015-11-29 19:36 GMT+03:00 Bram Moolenaar <[email protected]>: > > > > > > > > > > > > > > Patch 7.4.944 > > > > > Problem: Writing tests for Vim script is hard. > > > > > Solution: Add assertEqual(), assertFalse() and assertTrue() > functions. > > > > > Add > > > > > > > > > > > > > Why `assert{upper case letter}`? I know exactly no functions that > use this > > > > naming convention. > > > > > > Yes, it's different. There are some other functions with a capital, > > > > There are? Which ones? > > hlID() > synID() > synIDattr() > > diff_hlID() is nicely inconsistent.. >
Forgot about *ID* and thus incorrectly constructed the regex for search (only searched for functions which have exactly one capital letter). Though I still prefer `assert_equal`. Also I would not say that `assertEqual` is easier to read: due to its inconsistency it actually reads as “strange function name, *have a closer look and **double-check** this*”. Attention like this does not make any good; I saw other examples (e.g. Python: logging.Logger.addHandler which is against PEP8 that suggests add_handler) and (unless encountered many times recently) they always make me ask myself whether code is written right (when reading) or fail the expectations and make me go use the completion/documentation/code examples/… (when writing). > > > > but many more with an underscore, or just all lower case. > > > > > > But I do think that assertEqual() is easier to read than assertequal() > > > and it's shorter than assert_equal(). So do we prefer consistency or > > > nicer names? > > > > +1 for consistency and the underscore. > > Counting votes... > > -- > hundred-and-one symptoms of being an internet addict: > 160. You get in the elevator and double-click the button for the floor > you want. > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net > \\\ > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ > \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org > /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org > /// > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
