On Sun, Nov 29, 2015 at 10:01:02PM +0100, Bram Moolenaar wrote: > Christian Brabandt wrote:
> > On So, 29 Nov 2015, Bram Moolenaar wrote: > > > > > > > > Nikolay Pavlov wrote: > > > > > > > 2015-11-29 19:36 GMT+03:00 Bram Moolenaar <[email protected]>: > > > > > > > > > > > > > > Patch 7.4.944 > > > > > Problem: Writing tests for Vim script is hard. > > > > > Solution: Add assertEqual(), assertFalse() and assertTrue() > > > > > functions. > > > > > Add > > > > > > > > > > > > > Why `assert{upper case letter}`? I know exactly no functions that use > > > > this > > > > naming convention. > > > > > > Yes, it's different. There are some other functions with a capital, > > > > There are? Which ones? > hlID() > synID() > synIDattr() > diff_hlID() is nicely inconsistent.. > > > but many more with an underscore, or just all lower case. > > > > > > But I do think that assertEqual() is easier to read than assertequal() > > > and it's shorter than assert_equal(). So do we prefer consistency or > > > nicer names? > > > > +1 for consistency and the underscore. > Counting votes... +1 for nicer names, because, my opinion only, they make Bram happy -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
