Jason Schulz wrote: > Since C++ (Java, Python, etc...) have support for binary literals now, > I'm trying to add support for a 'bin' nrformat. So far, I've been > able to add it to sort, increment/decrement, key parsing, and some > other various functions. > > I would still need to add some tests, but I was hoping to get feedback > on what I have so far. As it currently works it could double the > stack space used for ASCII numbers (30 -> sizeof(unsigned long) * 8), > so I thought that may be one concern. > > This 'bin' nrformat actually ties into another feature I was > considering (radix conversion), so any feedback is much appreciated.
I don't think there is much use for binary in Vim script, but it doesn't hurt either. I suggest you write some documentation before tests. Then you have some hints about what to test. The number of arguments for vim_str2nr() is getting a bit large. It's probably better to turn dooct, dohex and dobin into one flag. -- hundred-and-one symptoms of being an internet addict: 209. Your house stinks because you haven't cleaned it in a week. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
