Hi Bram,

I appreciate you reviewing the patch so far.

> I don't think there is much use for binary in Vim script, but it doesn't
> hurt either.

I do use something similar in VimL to convert between radixes
(https://github.com/uxcn/vim-x2x).  It's strictly text in, text out though.

> I suggest you write some documentation before tests.  Then you have some
> hints about what to test.

I've written some documentation.  Currently the general things it adds are,

- support for 'bin' as an nrformat (default)
- a 'b' modifier to ':sort' for a binary format
- support for binary values ([0B|0b][01]+) as numbers
- support for incrementing/decrementing binary numbers
 
> The number of arguments for vim_str2nr() is getting a bit large.  It's
> probably better to turn dooct, dohex and dobin into one flag.

I'll try combining them into a single variable in the code.  I'll attach
another version of the patch once I have good documentation for it.  I've
already fixed a couple bugs in the first patch.

-Jason

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui