Hirohito Higashi wrote:

> I was refactoring the 'backspace' option of implementation.
> 
> The following patch was incomplete.
> (It's my first created and contributed patch! Four years ago...)
> 
> Patch 7.3.354
> Problem:    ":set backspace+=eol" doesn't work when 'backspace' has a 
>             backwards compatible value of 2.
> Solution:   Convert the number to a string. (Hirohito Higashi)
> Files:      src/option.c
> https://groups.google.com/d/topic/vim_dev/F3uFnrdYO3g/discussion
> 
> 
> A new patch has unified 'p_bs' variable handling to a string. So,
> remove the numerical reference process.

I don't think this works, using:
        :set bs=2
Still results in the "2" value.

When refactoring it's always good to first have a test, so we can check
if the behavior before and after is the same.  There is some testing of
'bs' in test29, but not much.


-- 
Microsoft: "Windows NT 4.0 now has the same user-interface as Windows 95"
    Windows 95: "Press CTRL-ALT-DEL to reboot"
Windows NT 4.0: "Press CTRL-ALT-DEL to login"

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui