Hi Bram and List, 2015-12-17(Thu) 21:30:43 UTC+9 Bram Moolenaar: > Hirohito Higashi wrote: > > > I was refactoring the 'backspace' option of implementation. > > > > The following patch was incomplete. > > (It's my first created and contributed patch! Four years ago...) > > > > Patch 7.3.354 > > Problem: ":set backspace+=eol" doesn't work when 'backspace' has a > > backwards compatible value of 2. > > Solution: Convert the number to a string. (Hirohito Higashi) > > Files: src/option.c > > https://groups.google.com/d/topic/vim_dev/F3uFnrdYO3g/discussion > > > > > > A new patch has unified 'p_bs' variable handling to a string. So, > > remove the numerical reference process. > > I don't think this works, using: > :set bs=2 > Still results in the "2" value.
Ah, I knew it. Probably I think that it be good when we unify the Vim internal management of the string, I was sent this patch. The reason for using the word refactoring you might've confused you. Before this patch: :set bs=2 :set bs? backspace=2 After this patch: :set bs=2 :set bs? backspace=indent,eol,start I think this is no problem :-) > > When refactoring it's always good to first have a test, so we can check > if the behavior before and after is the same. There is some testing of > 'bs' in test29, but not much. Also test38. Do I need send a modified document and add a test? -- Best regards, Hirohito Higashi (a.k.a h_east) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
