Oops, I failed to send to the list.  Sorry.

Kazunobu

---------- Forwarded message ----------
From: Kazunobu Kuriyama <[email protected]>
Date: 2016-02-22 13:03 GMT+09:00
Subject: Re: [Patch] GTK3 GUI
To: Bram Moolenaar <[email protected]>


Patch updated, made against v7.4.1385.

As I wrote last Saturday, this is a version I reviewed and revised by
myself for inclusion.

2016-02-20 22:42 GMT+09:00 Bram Moolenaar <[email protected]>:
Once it settles down we can change configure to use GTK 3 if it's
present.

Till then,  if you find anything wrong with the new GUI, please let me know.

Best regards,
Kazunobu

2016-02-21 0:09 GMT+09:00 Kazunobu Kuriyama <[email protected]>:

> 2016-02-20 22:42 GMT+09:00 Bram Moolenaar <[email protected]>:
>
>>
>> Kazunobu -
>>
>> I wonder if it's about time we include the GTK 3 changes?
>> I read that several people say it's working for them.
>> Keeping your patch in sync with the code changes can be avoided if we
>> include them.  We can always make further improvements.
>>
>
> Great.  That really helps me and will surely increase the opportunity of
> improvements.
>
> For that, I'd like to have tomorrow Sunday to check and review the patch
> for myself, since once the patch is included in the upstream, minor changes
> such as removing trailing spaces and empty lines must be a nuisance to
> other developers.  Also, I'd like to check if the patch is indeed logically
> correct.
>
> I'm thinking of posting a reviewed patch here after rebasing on commits
> you will probably do Sunday night (European time).
>
>>
>> I assume that the default would still be GTK 2 for now.
>>
>
> Right.
>
>
>> Once it settles down we can change configure to use GTK 3 if it's
>> present.  Perhaps it also requires a minimal version of GTK 3?
>>
>
> Although I haven't set any minimal version requirement, it is likely for
> the GUI not to fully work if a given GTK+ 3 is too old.   IIRC, SungHyun
> Nam reportedly used 3.10 (2013-09-23 released) and Christian Brabandt, 3.14
> (2014-09-30 released).  Is there anyone who tried the patch with a version
> older than these?
>
> Best regards,
> Kazunobu
>
>>
>> --
>> Overflow on /dev/null, please empty the bit bucket.
>>
>>  /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net
>>  \\\
>> ///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/
>> \\\
>> \\\  an exciting new programming language -- http://www.Zimbu.org
>> ///
>>  \\\            help me help AIDS victims -- http://ICCF-Holland.org
>> ///
>>
>
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: gtk3-v7.4.1385.patch.gz
Description: GNU Zip compressed data

Raspunde prin e-mail lui