2016-04-24 23:17 GMT+03:00 Dominique Pellé <[email protected]>: > Bram Moolenaar <[email protected]> wrote: > >> Hirohito Higashi wrote: >> >>> I think that 'guicolors' option name does not intuitive. >>> This option for terminal, but prefix is 'gui' >>> I think it's unnatural. >>> >>> I propose to rename option name to 'termtruecolor'. (Short name is 'ttc') >>> How about this? >>> >>> NOTE: >>> This has been first proposed by Ken Takada. >>> >>> Patch attached. >>> Please check this. >> >> Yes, I was wondering what users think of when seeing 'guicolors'. The >> main thing it does is using the GUI colors for the terminal. Whether >> it's actually true colors depends on the terminal. >> >> So, how about 'termguicolors'? >> >> Ah, I see Nikolai also suggested this. > > 'termguicolors' sounds good to me. But how about giving it > a value instead of being a boolean? So we can later > implement different values such as: > > - 1 for true colors terminal i.e. 16 million colors > - 2 for 256 color terminal > - 3 for 88 color terminal
I do not like options which use magic numbers. If this is enum option, it should be string option and not number (since VimL does not have enum type). Also why do you think that moving CSApprox into core is a good idea? There are other ways to make it faster. > > Dominique > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
