Re: [patch] 'guicolors' option name does not intuitive.

[Ken Takata]

Hi h_east,

2016/4/25 Mon 6:51:36 UTC+9 h_east wrote:
> Hi Bram and List!
> 
> 2016-4-25(Mon) 5:03:24 UTC+9 Bram Moolenaar:
> > Hirohito Higashi wrote:
> > 
> > > I think that 'guicolors' option name does not intuitive.
> > > This option for terminal, but prefix is 'gui'
> > > I think it's unnatural.
> > > 
> > > I propose to rename option name to 'termtruecolor'.  (Short name is 'ttc')
> > > How about this?
> > > 
> > > NOTE:
> > >   This has been first proposed by Ken Takada.
> > > 
> > > Patch attached.
> > > Please check this.
> > 
> > Yes, I was wondering what users think of when seeing 'guicolors'.  The
> > main thing it does is using the GUI colors for the terminal.  Whether
> > it's actually true colors depends on the terminal.
> > 
> > So, how about 'termguicolors'?
> > 
> > Ah, I see Nikolai also suggested this.
> 
> Yes, patch update.
> 
>   guicolors --> termguicolors
>   gcol --> tgc
>   termtruecolor --> termguicolors
>   FEAT_TERMTRUECOLOR --> FEAT_TERMGUICOLORS

I think it's also better to change function names.

Regards,
Ken Takata

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

# HG changeset patch
# Parent  41e70801eb39fe7e8a64763c84f29686ff0b0959

diff --git a/src/proto/term.pro b/src/proto/term.pro
--- a/src/proto/term.pro
+++ b/src/proto/term.pro
@@ -1,7 +1,7 @@
 /* term.c */
-guicolor_T termtrue_mch_get_color(char_u *name);
-guicolor_T termtrue_get_color(char_u *name);
-long_u termtrue_mch_get_rgb(guicolor_T color);
+guicolor_T termgui_mch_get_color(char_u *name);
+guicolor_T termgui_get_color(char_u *name);
+long_u termgui_mch_get_rgb(guicolor_T color);
 int set_termname(char_u *term);
 void set_mouse_termcode(int n, char_u *s);
 void del_mouse_termcode(int n);
diff --git a/src/term.c b/src/term.c
--- a/src/term.c
+++ b/src/term.c
@@ -1341,7 +1341,7 @@ hex_digit(int c)
 }
 
     guicolor_T
-termtrue_mch_get_color(char_u *name)
+termgui_mch_get_color(char_u *name)
 {
     guicolor_T	color;
     int		i;
@@ -1402,7 +1402,7 @@ termtrue_mch_get_color(char_u *name)
 	    if (STRICMP(line + pos, name) == 0)
 	    {
 		fclose(fd);
-		return (guicolor_T) RGB(r, g, b);
+		return (guicolor_T)RGB(r, g, b);
 	    }
 	}
 	fclose(fd);
@@ -1412,13 +1412,13 @@ termtrue_mch_get_color(char_u *name)
 }
 
     guicolor_T
-termtrue_get_color(char_u *name)
+termgui_get_color(char_u *name)
 {
     guicolor_T	t;
 
     if (*name == NUL)
 	return INVALCOLOR;
-    t = termtrue_mch_get_color(name);
+    t = termgui_mch_get_color(name);
 
     if (t == INVALCOLOR)
 	EMSG2(_("E254: Cannot allocate color %s"), name);
@@ -1426,9 +1426,9 @@ termtrue_get_color(char_u *name)
 }
 
     long_u
-termtrue_mch_get_rgb(guicolor_T color)
+termgui_mch_get_rgb(guicolor_T color)
 {
-    return (long_u) color;
+    return (long_u)color;
 }
 #endif
 
diff --git a/src/vim.h b/src/vim.h
--- a/src/vim.h
+++ b/src/vim.h
@@ -1607,7 +1607,7 @@ typedef UINT32_TYPEDEF UINT32_T;
 # endif
 #else
 # ifdef FEAT_TERMGUICOLORS
-#  define GUI_FUNCTION(f)	    termtrue_##f
+#  define GUI_FUNCTION(f)	    termgui_##f
 #  define USE_24BIT		    p_tgc
 # endif
 #endif