On Wednesday, 10 August 2016 02:35:04 UTC+2, Tony Mechelynck wrote: > Manuel: > > In the past there have been "unofficial" features published as patches > which remained outside of the "official" Vim repositories but publicly > available, sometimes for years, before Bram finally decided to take > them in. The +conceal and +float features, now part of mainstream Vim, > are two examples of such which I've seen remain "unofficial > third-party patches" while several successive minor versions of Vim > came and went. > > Maybe you could publish your patch (as a patch that could be applied > by running "patch -p1 ligatures.diff", or something like that, at the > top level of a Vim repository clone), upload it somewhere on github or > vim.org or wherever, and let anyone use it who wants. Then after > letting it bake there for some time, we'll know better how popular it > is. Assuming that the new version currently being made ready will be > called Vim 8.0 and be released before the end of 2016, we might then > have a poll about your patch when getting ready for 8.1 or 8.2, and > let's hope that that will arrive long before 8.0 is at patchlevel > 8.0.2200 — Vim 7.4, whose original release was almost exactly three > years ago, seems to have been quite successful in its own way. > > If you choose to go this way, please set it up so that it could be > disabled at compile-time (I mean, place the changes behind #ifdef > FEAT_LIGATURES or something equally distinctive), it will help it > being accepted into the main code, since anyone not wanting it would > be able to disable it at compile-time — and similarly, an option (to > enable or disable it at runtime if present at compile-time, let's say > in the vimrc or gvimrc before starting the GUI) would IMHO be equally > welcome. > > > Best regards, > Tony.
Hi Tony, you (and others) are making very good points here, and I appreciate the feedback. Following your suggestion, I have created a vim fork with a branch for this kind of development: https://github.com/manuelschiller/vim/tree/glyphs Currently, it contains two patches: - gui_gtk_x11: force shaping one character at a time for ASCII glyph cache This one does what it says. It'll get fonts like PragmataPro or Hasklig working in gvim without ligatures, and without the drawing caveats we discussed earlier. I imagine that this patch might make inclusion in vim quite a bit earlier (I'd hope soonish, but that may be wishful thinking) than the next item, because I do not think it does anything controversial. If you'd like to see style improvements etc., please let me know, I'm happy to accomodate you. :) - gui_gtk_x11: enable poor man's ligatures This one is the bit that enables ligatures, and will require a couple of iterations on my side before it's ready to be considered for inclusion. (For example, I'd like to make the set of characters that disable the ASCII glyph cache user-configurable, and I have to find out how C code gets access to variables inside vimscript...) For the curious, this is something they might want to try out, and give feedback... I would again like to thank you all for the friendly and constructive atmosphere. And let me know if you have suggestions, please! Manuel -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
