Hirohito Higashi wrote:
> Hi Bram and developers,
>
> I checked in 7.4.2321
>
> ==== Case 1 ====
> How to reproduce:
> - Create the following file:
> $ cat sample1.vim
> edit a.txt
> augroup sample
> autocmd!
> autocmd BufUnload <buffer> tabfirst | 2bwipeout!
> augroup END
> edit b.txt
>
> - Run vanilla Vim with above script file
> $ vim -Nu NONE -S sample1.vim
>
> Expected behavior:
> SEGV does not occur.
>
> Actual behavior:
> SEGVed.
>
>
>
> ==== Case 2 ====
> How to reproduce:
> - Create the following file:
> $ cat sample2.vim
> setlocal buftype=nowrite
> augroup sample
> autocmd!
> autocmd BufUnload <buffer> tabfirst | 2bwipeout
> augroup END
> normal! i1
> edit a.txt
> call feedkeys("\<CR>")
>
> - Run vanilla Vim with above script file
> $ vim -Nu NONE -S sample2.vim
>
> Expected behavior:
> SEGV does not occur.
>
> Actual behavior:
> SEGVed.
>
>
> I know there are rare case and salicious scripts.
> But, It is not good to SEGV.
>
> I wrote a patch. --> `fix_autocmd_bufunload_with_bwipe.patch`
> check it out.
I think we need a more drastic solution. Autocommands wiping out a
buffer that we rely on should not happen. We already had the b_closing
flag, let's turn that into a b_locked flag.
> I've also written test. --> `autocmd_bufunload_with_bwipe_test.patch`
> Unfortunately, it did not SEGV in the pre-patch binary :-/
That's because it deletes buffer 2, but in the test the buffer number
will be higher. I managed to get the crash using bufnr('$') + 1.
> NOTE: This issue was reported by Norio Takagi. (Thanks!)
--
You're as much use as a condom machine at the Vatican.
-- Rimmer to Holly in Red Dwarf 'Queeg'
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
