Hi ChrisBra, Bram and list!
2016-9-12(Mon) 2:56:04 UTC+9 Christian Brabandt:
> On So, 11 Sep 2016, h_east wrote:
>
> > Hi ChrisBra, Bram and list,
> > 2016-7-24(Sun) 0:36:14 UTC+9 Christian Brabandt:
> > > On Sa, 23 Jul 2016, Bram Moolenaar wrote:
> > > > Christian Brabandt wrote:
> > > I think I also found a bug, and this makes the test currently fail.
> > > Take this example from the test:
> > >
> > > (The popupmenu is the one from the help for all months)
> > > The initial state of the buffer is this:
> > > ,----
> > > | D
> > > | December2015
> > > `----
> >
> > I have investigated this behavior.
> >
> > Related vim_dev threads:
> > - Patch 7.4.2146
> > https://groups.google.com/d/msg/vim_dev/75ZXlRlBzl4/DDnqvSn9BgAJ
> > - [vim/vim] VIM 7.4: Possible regression via patch 2146? (#972)
> > https://groups.google.com/d/msg/vim_dev/mQ2YacpOKvo/vOsgkU-2AQAJ
> > - Patch 7.4.2188
> > https://groups.google.com/d/msg/vim_dev/e2Rr8Px3qkQ/1XWiAQ0LAgAJ
> >
> > I think the series of <C-E> behavior is correct.
>
> okay.
>
> > > ,----
> > > | Dece
> > > |
> > > | December2015
> > > `----
> > > (because after inserting the match <c-e> is still in popupmenu mode and
> > > "ends completion and goes back to what was there before selecting a
> > > match")
> > >
> > > However, a total mystery is to me, when the test is run, it will
> > > complete to
> > >
> > > ,----
> > > | December2015
> > > | December2015
> > > | December2015
> > > `----
> >
> > Hmm?, I got the following result. (make test_popup in 7.4.2358)
> >
> > 1 FAILED:
> > Found errors in Test_popup_complete2():
> > function RunTheTest[9]..Test_popup_complete2 line 10: Expected
> > ['December2015', '', 'December2015'] but got ['Dece', '', 'December2015']
> >
> > I think `['Dece', '', 'December2015']` is right.
>
> Okay then we can enable the test again and need to change the test
> assert.
I changed test_popup.vim
I was wondering if you can check an attached patch?
I would like you to check the mainly English sentence 👍
Thank you
--
Best regards,
Hirohito Higashi (a.k.a. h_east)
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/testdir/test_popup.vim b/src/testdir/test_popup.vim
index 6e07393..eae8bc3 100644
--- a/src/testdir/test_popup.vim
+++ b/src/testdir/test_popup.vim
@@ -17,16 +17,18 @@ func! ListMonths()
endfunc
func! Test_popup_complete2()
- " Insert match immediately, if there is only one match
- " <c-e> Should select a character from the line below
- " TODO: test disabled because the code change has been reverted.
- throw "Skipped: Bug with <c-e> and popupmenu not fixed yet"
+ " 'the popup menu is not visible' is not equivalent to 'the completion mode
+ " is not active'.
+ " After the type <F5>, Vim still stay in the first state of the completion
+ " mode. It is not related to the visible of popup.
+ " So that, the first <C-E> behavior is `complete_CTRL-E`, and the second and
+ " more <C-E> is `i_CTRL_E`
new
inoremap <f5> <c-r>=ListMonths()<cr>
call append(1, ["December2015"])
:1
call feedkeys("aD\<f5>\<C-E>\<C-E>\<C-E>\<C-E>\<enter>\<esc>", 'tx')
- call assert_equal(["December2015", "", "December2015"], getline(1,3))
+ call assert_equal(["Dece", "", "December2015"], getline(1,3))
%d
bw!
endfu
