On Thu, Jan 05, 2017 at 07:19:07PM +0300, Nikolay Aleksandrovich Pavlov wrote:
> The reason is obvious: everywhere where you see short list of commit
> messages (github PRs commit list, github project commit list, thread
> titles in the mailing list, some git commands, some github automatic
> emails (I mainly see emails of Neovim PRs with ports)) you immediately
> see only title line. Seeing just “patch …” here is highly inconvenient
> there, this contains almost no information.
I agree that Bram's commit format leaves something to be desired. Let's
say Bram changed the commit format so that the first line was "Fix
$PROBLEM." If we use Git's recommended summary length of 50 characters,
that means the $PROBLEM needs to be at most 46 characters. An adhoc awk
script shows that close to half of the last 1000 commits could fit:
$ git log -1000 | awk '/Problem:/ {
$1 = ""
gsub(/^[ \t]+|[ \t]+$/, "")
t++
n += length() <= 46
}
END {
print "Total:",t
print "Fit:", n
}'
Total: 939
Fit: 437
I suspect a lot more than that could fit because Bram often adds the
author or reporter's name to the end of the messages. If you change the
length to 76 (strlen("Fix $PROBLEM") <= 80), almost all of the commits
fit (note that the above script won't provide an accurate number for
that). Having an initial message with a descriptive commit would make it
a lot easier to do things like using Git's interactive modes for
rebasing and bisecting.
Eric
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
