Nikolay wrote: > 2017-01-05 4:08 GMT+03:00 Daniel Moch <[email protected]>: > > On Wed, Jan 04, 2017 at 08:43:01PM +0100, Dimitri Merejkowsky wrote: > >> So I suggest instead to negate the 'problem' part, keep the solution' part > >> as a body, and add a blank line. > >> > >> Thus the commit message would look like: > >> > >> > patch 8.0.0142: Fix normal colors when used with 'termguicolors'. > >> > > >> > Initialize to INVALCOLOR instead of zero. (Ben Jackson, closes #1344) > > > > One issue with your proposal is that it creates the likelihood of the > > 'title' line being longer than it should be (you refer to tpope's > > article, where he suggests keeping it to 50 characters or less). In any > > case, we're talking about guidelines and I don't see any reason to ask > > Bram to change the way he works. > > I know no reasons to keep it 50 characters nowadays: tpope refers to > 80-character-wide terminal and I never used such for developing and > have no reasons to think other developers deliberately limit > themselves to 80-character-wide terminals on desktop (80x24 terminals > were for old 4:3 screens with big pixels, modern screens are normally > something like 16:9, often bigger and have much, much less pixel size: > this makes 80x24 terminals either use very huge font size or occupy > little space on screen). But there is a reason to limit title to 70 > characters: after 70 characters github truncates even the title line, > and I also limit commit message body to 80 characters (because it is > default &textwidth; personally I am fine with 110: my terminal is > 119+119+(split column) wide when splitted in two parts by Vim or > tmux). > > The reason is obvious: everywhere where you see short list of commit > messages (github PRs commit list, github project commit list, thread > titles in the mailing list, some git commands, some github automatic > emails (I mainly see emails of Neovim PRs with ports)) you immediately > see only title line. Seeing just “patch …” here is highly inconvenient > there, this contains almost no information.
Github truncates the title, thus if we put the Problem there we won't get the whole text. Other solutions would be to have a summary first, like the README on the ftp site, and then the whole Problem and Solution as the body. Not sure if anybody depends on the current text. I can try it out with the next patch. -- What is the difference between a professional and an amateur? The ark was built by an amateur; professionals gave us the Titanic. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
