[patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

[h_east]

Hi Bram and list,

My config:
  $ ./configure --with-features=huge --enable-gui=gnome2 
--enable-fail-if-missing
My env.:
  I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
Vim version:
  8.0.502

Executed command:
  $ cd vim/src
  $ make test

Execution result:
I got the following error.
-------->8--------
Test results:


>From test_clientserver.vim:
Found errors in Test_client_server():
First run:
function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' does 
not match ''
Caught exception in Test_client_server(): Vim(call):E240: No connection to the 
X server @ function RunTheTest[24]..Test_client_server, line 19
Second run:
function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' does 
not match ''
Caught exception in Test_client_server(): Vim(call):E240: No connection to the 
X server @ function RunTheTest[24]..Test_client_server, line 19

>From test_quotestar.vim:
Found errors in Test_quotestar():
First run:
function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 21: 
Pattern 'XVIMCLIPBOARD' does not match ''
Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
server @ function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, 
line 31
Second run:
function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 21: 
Pattern 'XVIMCLIPBOARD' does not match ''
Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
server @ function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, 
line 31
TEST FAILURE
Makefile:41: recipe for target 'report' failed
make[1]: *** [report] Error 1
make[1]: Leaving directory '/home/h_east/samba/github/vim/src/testdir'
Makefile:2027: recipe for target 'scripttests' failed
make: *** [scripttests] Error 2
-------->8--------

I think that it is not necessary to carry out test at the following conditions.

if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
  finish
endif


Also, the following code is always true, so we should modify it.
src/testdir/test_quotestar.vim : 112

  elseif !empty("$DISPLAY")


I attached a patch.
Check it please.
--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

diff --git a/src/testdir/test_clientserver.vim b/src/testdir/test_clientserver.vim
index c98fc02..ce6d247 100644
--- a/src/testdir/test_clientserver.vim
+++ b/src/testdir/test_clientserver.vim
@@ -1,5 +1,8 @@
 " Tests for the +clientserver feature.
 
+if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
+  finish
+endif
 if !has('job') || !has('clientserver')
   finish
 endif
diff --git a/src/testdir/test_quotestar.vim b/src/testdir/test_quotestar.vim
index d0dd04f..e67bef8 100644
--- a/src/testdir/test_quotestar.vim
+++ b/src/testdir/test_quotestar.vim
@@ -1,5 +1,8 @@
 " *-register (quotestar) tests
 
+if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
+  finish
+endif
 if !has('clipboard')
   finish
 endif
@@ -109,7 +112,7 @@ func Test_quotestar()
 
   if has('macunix')
     let skipped = Do_test_quotestar_for_macunix()
-  elseif !empty("$DISPLAY")
+  elseif !empty($DISPLAY)
     let skipped = Do_test_quotestar_for_x11()
   else
     let skipped = "Test is not implemented yet for this platform."