2017-03-26 0:49 GMT+09:00 h_east <[email protected]>:
> Hi Bram and list,
>
> 2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> > I wrote:
> >
> > > Hirohito Higashi wrote:
> > >
> > > > > > > > My config:
> > > > > > > > $ ./configure --with-features=huge --enable-gui=gnome2
> --enable-fail-if-missing
> > > > > > > > My env.:
> > > > > > > > I am connecting to fedora 25 with ssh via PuTTY on Windows
> 7.
> > > > > > > > Vim version:
> > > > > > > > 8.0.502
> > > > > > > >
> > > > > > > > Executed command:
> > > > > > > > $ cd vim/src
> > > > > > > > $ make test
> > > > > > > >
> > > > > > > > Execution result:
> > > > > > > > I got the following error.
> > > > > > > > -------->8--------
> > > > > > > > Test results:
> > > > > > > >
> > > > > > > >
> > > > > > > > >From test_clientserver.vim:
> > > > > > > > Found errors in Test_client_server():
> > > > > > > > First run:
> > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> > > > > > > > Second run:
> > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> > > > > > >
> > > > > > > Why is there no connection to the X server? Anyway, we could
> catch this
> > > > > > > error and give up.
> > > > > >
> > > > > > There might be the case one builds vim on a headless system. I.e.
> > > > > > some build servers of distro's?
> > > > >
> > > > > Can you try this patch:
> > > > >
> > > > >
> > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> > > > > +++ testdir/test_clientserver.vim 2017-03-22
> 22:19:57.761651837 +0100
> > > > > @@ -11,6 +11,12 @@
> > > > > if cmd == ''
> > > > > return
> > > > > endif
> > > > > + try
> > > > > + call serverlist()
> > > > > + catch /E240:/
> > > > > + " No connection to the X server, give up.
> > > > > + finish
> > > > > + endtry
> > > > >
> > > > > let name = 'XVIMTEST'
> > > > > let cmd .= ' --servername ' . name
> > > >
> > > > In my environment, `:call serverlist()` always succeed and returns
> the empty string.
> > > > So, above patch does not change the situation.
> > >
> > > It appears serverlist() can fail silently.
> > >
> > > Try this check instead:
> > >
> > > func Test_client_server()
> > > let cmd = GetVimCommand()
> > > if cmd == ''
> > > return
> > > endif
> > > if has('unix')
> > > try
> > > call remote_send('xxx', '')
> > > catch
> > > if v:exception =~ 'E240:'
> > > " No connection to the X server, give up.
> > > finish
> >
> > That should be "return".
> >
> > > endif
> > > " ignore other errors
> > > endtry
> > > endif
>
> Thanks for the fixing this issue at Patch 8.0.0507 👍
>
> Please also fix the following one as reported first. I attached a patch.
>
> > Also, the following code is always true, so we should modify it.
> > src/testdir/test_quotestar.vim : 112
> >
> > elseif !empty("$DISPLAY")
>
Now that a TRY statement which checks whether or not a connection to the X
server is established at runtime is added, that ELSEIF condition would be
better replaced with has('x11'); otherwise, it's simply redundant and the
statement which is to be thrown at the succeeding ELSE statement wouldn't
make sense.
> --
> Best regards,
> Hirohito Higashi (a.k.a. h_east)
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
