Ken Takata wrote: > I found some issues with the terminal feature (mainly on Windows): > > * Couldn't build with VC2010, because libvterm requires stdbool.h. > Reuse if_perl_msvc/stdbool.h for this. > (Maybe it's better to change the directory name "if_perl_msvc", but I didn't > do it this time.)
Only one file includes stdbool.h. It's easy enough to change true and false to TRUE and FALSE, like we do in Vim. > * vterm.lib was not build automatically by Make_mvc.mak. Add it to the > dependency of vim.exe. > (src/Makefile doesn't build libvterm.a and compiles/links it directly. > Maybe it's better to do the same thing for src/Make_mvc.mak and > src/Make_cyg_ming.mak, because we cannot build both 32- and 64-bit vim.exe > in the same directory when the terminal feature is enabled.) > > * Winpty didn't work with 32-bit vim.exe. Fix some function declarations. > > * Fix crash when 'encoding' isn't "utf-8". > > * Fix document. > - Fix typos. > - Move instructions for installing winpty to runtime/doc/terminal.txt from > src/INSTALLpc.txt > - etc. > > Please check the attached patch. Thanks! -- hundred-and-one symptoms of being an internet addict: 235. You start naming your kids Pascal, COBOL, Algol and Fortran. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
