Ken Takata wrote:

> 2017/7/25 Tue 5:29:46 UTC+9 Bram Moolenaar wrote:
> > Ken Takata wrote:
> > 
> > > I found some issues with the terminal feature (mainly on Windows):
> > > 
> > > * Couldn't build with VC2010, because libvterm requires stdbool.h.
> > >   Reuse if_perl_msvc/stdbool.h for this.
> > >   (Maybe it's better to change the directory name "if_perl_msvc", but I 
> > > didn't
> > >   do it this time.)
> > 
> > Only one file includes stdbool.h.  It's easy enough to change true and
> > false to TRUE and FALSE, like we do in Vim.
> 
> I think you edited a wrong file in the patch 8.0.0769.
> pen.c should have been edited. Moreover, vterm.h incudes stdbool.h.
> Attached patch fixes the problem.

Somehow my grep missed that.  I'll make a separate patch for this.

> > > * vterm.lib was not build automatically by Make_mvc.mak. Add it to the
> > >   dependency of vim.exe.
> > >   (src/Makefile doesn't build libvterm.a and compiles/links it directly.
> > >   Maybe it's better to do the same thing for src/Make_mvc.mak and
> > >   src/Make_cyg_ming.mak, because we cannot build both 32- and 64-bit 
> > > vim.exe
> > >   in the same directory when the terminal feature is enabled.)
> 
> Attached patch also applies these changes.
> Now we can build both 32- and 64-bit versions in the same directory.
> (Actually, object files are stored in different directories, however the
> executable files are written in the src/ directory, so they can be
> overwritten.)

I suppose it was getting too complicated to keep the Makefile under
libvterm.  Oh well, we are not getting to have this included in the
libvterm distribution then.

There were a few merge conflicts, please check the patch.

-- 
If you're sending someone Styrofoam, what do you pack it in?

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui