Hi Bram,

2017/10/9 Mon 0:59:06 UTC+9 Bram Moolenaar wrote:
> Patch 8.0.1183
> Problem:    MS-Windows build instructions are outdated.
> Solution:   Update instructions for MSVC 2015.  Update the build script.
> Files:      Filelist, Makefile, src/INSTALLpc.txt, src/bigvim.bat

I think I found some mistakes in this patch.


> + build a 64 bit Vim if you like, the executable will be bigger and Vim wan't 
> be

Maybe, "won't" instead of "wan't"?


> ! needed to target Windows XP.  But not older Windows versions (95, 97), see

s/97/98/


> !     Note that ruby_2_4 is the branch name for Ruby 2.4.X's source code.
>       There is no need to build whole Ruby, just config.h is needed.
>       If you use 32-bit MSVC10, the config.h is generated in the

"MSVC10" should be replaced with "MSVC 2015".

> !     .ext\include\i386-mswin32_140 directory.
>   
>     3) Install the generated config.h.
>   
> !       xcopy /s .ext\include E:\Ruby24\include\ruby-2.4.0

"E:\Ruby24" should be "C:\Ruby24", because it is described in above part that
RubyInstaller is installed in "C:\Ruby24" in this example.


I also found some points which should be updated:

* Msys2 install directory was wrong.  32-bit version is normally installed in
  C:\msys32, not C:\msys2.
* No need to set ARCH on MinGW anymore.
* Use "C:/foo/bar" style instead of "C:\foo\bar" on MinGW.  Backslashes don't
  work as expected when mingw32-make is executed from bash instead of cmd.exe.
  "C:/foo/bar" style works fine on both bash and cmd.exe.
* Ruby version was not updated on MinGW.

Please check the attached patch.

Regards,
Ken Takata

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.
# HG changeset patch
# Parent  46745fa483408cf384144a4e912a8f0faacba995

diff --git a/src/INSTALLpc.txt b/src/INSTALLpc.txt
--- a/src/INSTALLpc.txt
+++ b/src/INSTALLpc.txt
@@ -16,7 +16,7 @@ XP/2003/Vista/7/8/10).  There are also i
 they might no longer work.
 
 The recommended way is to build a 32 bit Vim, also on 64 bit systems.  You can
-build a 64 bit Vim if you like, the executable will be bigger and Vim wan't be
+build a 64 bit Vim if you like, the executable will be bigger and Vim won't be
 any faster, but you can edit files larger than 2 Gbyte.
 
 
@@ -42,7 +42,7 @@ 16. Installing after building from sourc
 
 The currently recommended way (that means it has been verified to work) is
 using the "Visual Studio Community 2015" installation.  This includes the SDK
-needed to target Windows XP.  But not older Windows versions (95, 97), see
+needed to target Windows XP.  But not older Windows versions (95, 98), see
 |msvc-2008-express| below for that
 
 
@@ -285,17 +285,11 @@ your AUTOEXEC.BAT file with a line like:
 
 or on NT/2000/XP, go to the Control Panel, (Performance and Maintenance),
 System, Advanced, and edit the environment from there. If you use msys2
-compilers, set your installed paths:
-
-    C:\msys2\mingw32\bin
-or
-    C:\msys64\mingw32\bin
+compilers, set your installed paths (normally one of the following):
 
-for 32bit. And 64bit:
-
-    C:\msys2\mingw64\bin
-or
-    C:\msys64\mingw64\bin
+    C:\msys32\mingw32\bin   (32-bit msys2, targeting 32-bit builds)
+    C:\msys64\mingw32\bin   (64-bit msys2, targeting 32-bit builds)
+    C:\msys64\mingw64\bin   (64-bit msys2, targeting 64-bit builds)
 
 Test if gcc is on your path.  From a CMD (or COMMAND on '95/98) window:
 
@@ -430,9 +424,9 @@ And if you use msys2 to build python sup
         DYNAMIC_PYTHON=yes
         PYTHON_VER=27
         DYNAMIC_PYTHON_DLL=libpython2.7.dll
-        ARCH=x86-64
         STATIC_STDCPLUS=yes
 
+(This is for 64-bit builds.  For 32-bit builds, replace mingw64 with mingw32.)
 You will end up with a Python-enabled, Win32 version. Enjoy!
 
 
@@ -590,7 +584,7 @@ E.g. When using MSVC (as one line):
 Or when using MinGW (as one line):
 
     mingw32-make -f Make_ming.mak
-        LUA=C:\projects\lua53 DYNAMIC_LUA=yes LUA_VER=53
+        LUA=C:/projects/lua53 DYNAMIC_LUA=yes LUA_VER=53
 
 
 Or when using Cygwin (as one line) (untested):
@@ -622,7 +616,7 @@ E.g. When using MSVC (as one line):
 Or when using MinGW (as one line):
 
     mingw32-make -f Make_ming.mak
-        PERL=C:\Perl DYNAMIC_PERL=yes PERL_VER=522
+        PERL=C:/Perl DYNAMIC_PERL=yes PERL_VER=522
 
 
 11. Building with Ruby support
@@ -684,12 +678,12 @@ config.h and Ruby's DLL name. Here are t
 
     Note that ruby_2_4 is the branch name for Ruby 2.4.X's source code.
     There is no need to build whole Ruby, just config.h is needed.
-    If you use 32-bit MSVC10, the config.h is generated in the
+    If you use 32-bit MSVC 2015, the config.h is generated in the
     .ext\include\i386-mswin32_140 directory.
 
   3) Install the generated config.h.
 
-      xcopy /s .ext\include E:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
 
     Note that 2.4.0 is Ruby API version of Ruby 2.4.X.
     You may need to close the console and reopen it to pick up the new $PATH.
@@ -712,7 +706,7 @@ Using MinGW is easier than using MSVC wh
 After you install RubyInstaller, just type this (as one line):
 
     mingw32-make -f Make_ming.mak
-        RUBY=C:/Ruby22 DYNAMIC_RUBY=yes RUBY_VER=22 RUBY_API_VER_LONG=2.2.0
+        RUBY=C:/Ruby24 DYNAMIC_RUBY=yes RUBY_VER=24 RUBY_API_VER_LONG=2.4.0
         WINVER=0x501
 
 If you set WINVER explicitly, it must be set to >=0x500, when building with
@@ -749,7 +743,7 @@ E.g. When using MSVC (as one line):
 Or when using MinGW (as one line):
 
     mingw32-make -f Make_ming.mak
-        TCL=C:\Tcl86 DYNAMIC_TCL=yes TCL_VER=86 TCL_VER_LONG=8.6
+        TCL=C:/Tcl86 DYNAMIC_TCL=yes TCL_VER=86 TCL_VER_LONG=8.6
 
 
 13. Building with Terminal support

Raspunde prin e-mail lui