Ken Takata wrote:

> 2017/10/9 Mon 0:59:06 UTC+9 Bram Moolenaar wrote:
> > Patch 8.0.1183
> > Problem:    MS-Windows build instructions are outdated.
> > Solution:   Update instructions for MSVC 2015.  Update the build script.
> > Files:      Filelist, Makefile, src/INSTALLpc.txt, src/bigvim.bat
> 
> I think I found some mistakes in this patch.
> 
> 
> > + build a 64 bit Vim if you like, the executable will be bigger and Vim 
> > wan't be
> 
> Maybe, "won't" instead of "wan't"?
> 
> 
> > ! needed to target Windows XP.  But not older Windows versions (95, 97), see
> 
> s/97/98/
> 
> 
> > !     Note that ruby_2_4 is the branch name for Ruby 2.4.X's source code.
> >       There is no need to build whole Ruby, just config.h is needed.
> >       If you use 32-bit MSVC10, the config.h is generated in the
> 
> "MSVC10" should be replaced with "MSVC 2015".
> 
> > !     .ext\include\i386-mswin32_140 directory.
> >   
> >     3) Install the generated config.h.
> >   
> > !       xcopy /s .ext\include E:\Ruby24\include\ruby-2.4.0
> 
> "E:\Ruby24" should be "C:\Ruby24", because it is described in above part that
> RubyInstaller is installed in "C:\Ruby24" in this example.
> 
> 
> I also found some points which should be updated:
> 
> * Msys2 install directory was wrong.  32-bit version is normally installed in
>   C:\msys32, not C:\msys2.
> * No need to set ARCH on MinGW anymore.
> * Use "C:/foo/bar" style instead of "C:\foo\bar" on MinGW.  Backslashes don't
>   work as expected when mingw32-make is executed from bash instead of cmd.exe.
>   "C:/foo/bar" style works fine on both bash and cmd.exe.
> * Ruby version was not updated on MinGW.
> 
> Please check the attached patch.

I'll include it, thanks.

-- 
Facepalm statement #2: "If there is a country without immigrants I'm going to
move there"

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui