Christian Brabandt wrote: > On Mo, 12 Feb 2018, Bram Moolenaar wrote: > > Not sure this is true. If two lines are added after orig_line_count was > > set, and one line gets deleted, then orig_line_count should not change. > > If the total number of lines decreases below orig_line_count then > > orig_line_count does need to be adjusted. Hmm, something like that, > > need some actual scenarios to check what really happens. > > [writing more tests] > > > Please do. And please add comments to those global variables, so that > > it's clear what they mean exactly (not just what they are used for). > > I'm trying to do this for all these state variables (as far as I can > > understand them, insert completion is another area where it's not 100% > > clear). > > > > It's been a bit late, but here is an updated patch, that checks that > orig_line_count is still valid in virtual replace mode and adds a couple > of more tests. > > I think I addressed all of your points above.
Thanks! Running the test without the change in edit.c causes a crash. Nice fix. -- DENNIS: Look, strange women lying on their backs in ponds handing out swords ... that's no basis for a system of government. Supreme executive power derives from a mandate from the masses, not from some farcical aquatic ceremony. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.