On Di, 06 Mär 2018, Bram Moolenaar wrote:

> 
> Christian Brabandt wrote:
> 
> > On Mo, 12 Feb 2018, Bram Moolenaar wrote:
> > > Not sure this is true.  If two lines are added after orig_line_count was
> > > set, and one line gets deleted, then orig_line_count should not change.
> > > If the total number of lines decreases below orig_line_count then
> > > orig_line_count does need to be adjusted.  Hmm, something like that,
> > > need some actual scenarios to check what really happens.
> > 
> > [writing more tests]
> > 
> > > Please do.  And please add comments to those global variables, so that
> > > it's clear what they mean exactly (not just what they are used for).
> > > I'm trying to do this for all these state variables (as far as I can
> > > understand them, insert completion is another area where it's not 100%
> > > clear).
> > > 
> > 
> > It's been a bit late, but here is an updated patch, that checks that 
> > orig_line_count is still valid in virtual replace mode and adds a couple 
> > of more tests.
> > 
> > I think I addressed all of your points above.
> 
> Thanks!  Running the test without the change in edit.c causes a crash.
> Nice fix.

Looks like the test broke on Windows:
https://ci.appveyor.com/project/chrisbra/vim/build/5036/job/c6ixm79w9pcbgdeg#L1528
,----
| From test_visual.vim:
| Found errors in Test_virtual_replace():
| Caught exception in Test_virtual_replace(): Vim(set):E522: Not found in 
termcap: t_kD&vim  @ function RunTheTest[38]..Test_virtual_replace, line 30
| TEST FAILURE 
| NMAKE : fatal error U1077: 'if' : return code '0x1'
| Stop.
| Command exited with code 2
`----

I guess t_kD should only be reset on non Windows builds then.

Best,
Christian
-- 
Ist man in kleinen Dingen nicht geduldig, bringt man die großen
Vorhaben zum Scheitern.
                -- Konfuzius (551-479 v. Chr.)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui