Hi, On Tue, May 29, 2018 at 7:54 AM, Jason Franklin <[email protected]> wrote: > This patch fixes a minor bug with the quickfix window. It also makes a small > improvement and does some refactoring. > > To reproduce the bug: > > vim -u NONE > :copen > <C-W><CR> > > ... note that you get an error message and a window still opens. A window > should not open. > > The refactoring is farily obvious. Callbacks for "<CR>" and "CTRL-W <CR>" in > the quickfix window are moved into "quickfix.c". This seems like the natural > place for these functions. > > The improvement is somewhat nice. If the split succeeds, we clear the > jumplist > in the new window with the ":clearjumps" command. This means that we can't > jump back to the quickfix list in the new window (we don't want two quickfix > lists). > > As usual, a test is included to make sure that the bug remains fixed. >
Some comments/suggestions about the patch: Is it possible to merge the qf_view_result() and qf_view_result_split() functions into a single function with a "split" argument? Instead of using sprintf(), can you use vim_snprintf()? In the test, can you use the g:Xsetlist, Xopen and Xclose command/function and merge the test for quickfix and location list into a single test? - Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
